Conversation
* fix: docs dead links * fix: add /en prefix to english docs
- Upgrade manifest version from v2 to v3 with updated permissions format - Migrate background scripts to service worker - Update content_security_policy and web_accessible_resources format - Replace browser_action with action - Upgrade react and react-dom from v16 to v18 in g-devtool - Update devtool UI to support React 18 createRoot API - Maintain backward compatibility with legacy versions - Update minimum chrome version requirement to 88
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @wang1212, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant update to the g-devtool Chrome extension, migrating it to Manifest V3 for future compatibility. Concurrently, the project's core React dependencies have been upgraded to version 18, with necessary code adjustments to ensure seamless integration. Additionally, a comprehensive review and update of documentation links across the site have been performed to reflect these and other structural changes, improving overall clarity and accuracy for users.
Highlights
- Chrome Extension Manifest V3 Migration: The Chrome extension's manifest file has been upgraded from Manifest V2 to Manifest V3, including updates to permissions, content security policy, and resource declarations. This ensures continued compatibility with modern Chrome browser versions.
- React Version Upgrade and Compatibility: The project's React and React DOM dependencies have been updated to version 18.2.0, bringing the latest features and performance improvements. Compatibility logic has been added to support React 18's
createRootAPI while maintaining support for older React versions. - Documentation Link Updates: Numerous internal documentation links and example paths across the site have been updated to reflect changes in the documentation structure and to ensure accuracy.
- Developer Tooling and Documentation Clarity: The
g-devtoolREADME now includes a clear notice about the Manifest V3 update, advising users to reload the extension, and the S2 integration example has been simplified for better clarity.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request appears to be a release, primarily focused on updating the Chrome devtool extension to Manifest V3 and upgrading React to version 18. The changes for the Manifest V3 migration are thorough and correct, including updates to permissions, content security policy, and API calls. The React upgrade is also handled well with backward compatibility in mind. Additionally, there are numerous documentation updates to align links with a new site structure. I've identified one issue in a generated license file where image data seems to have been mistakenly included, which should be addressed.
| /** */ | ||
|
|
||
| /** */ | ||
|
|
||
| /** */ | ||
|
|
||
| /** */ |
There was a problem hiding this comment.
It appears that some base64 encoded SVG images have been erroneously included in this license file as comments. This is likely a build process artifact and should be removed to keep the license file clean and accurate.
- Add new GitHub Actions workflow 'bug-report-reproduction-check' - Automatically analyze new bug reports for reproduction steps - Use Mistral AI to check for complete reproduction information - Add friendly comment when reproduction details are missing - Only trigger for issues labeled as 'bug' - Add necessary permissions for issues and models access
Fix the YAML indentation for the github-script action to properly format the comment response in the bug report workflow.
- Add GitHub Actions workflow for generating weekly issue summaries - Include prompt template for issue summarization using gh-models - Schedule to run every Monday at 09:00
- Add GitHub Actions workflow to generate monthly issue metrics reports - Schedule to run on the 1st day of each month - Use github/issue-metrics to track issue statistics - Automatically create an issue with the metrics report This will help track and visualize issue metrics over time.
1 participant
No description provided.