Skip to content

fix: LineLayer shape 切换后重建模型 #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lzxue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: LineLayer shape 切换后重建模型 #2841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/layers/src/line/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ export default class LineLayer extends BaseLayer<ILineLayerStyleOptions> {
await this.initLayerModels();
}

public async rebuildModels() {
await this.buildModels();
}
Comment on lines +37 to +39

@gemini-code-assist gemini-code-assist Bot Mar 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

rebuildModels 方法已经在基类 BaseLayer 中以完全相同的逻辑实现。由于 LineLayer 继承自 BaseLayer，这个显式的覆盖是多余的，可以移除以简化代码。继承的方法会调用 this.buildModels()，并正确地解析为 LineLayer 中的实现。


protected getDefaultConfig() {
const type = this.getModelType();
const defaultConfig = {
Expand Down
Loading