IOS-5365 implement the async membership handling #4111
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| MIDDLE_VERSION=go-6337-make-tiersmembership-fetching-async | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| // DO NOT EDIT. | ||
| // swift-format-ignore-file | ||
| // swiftlint:disable all | ||
| // | ||
| // Generated by the Swift generator plugin for the protocol buffer compiler. | ||
| // Source: pb/protos/events.proto | ||
| // | ||
| // For information on using the generated types, please see the documentation: | ||
| // https://github.com/apple/swift-protobuf/ | ||
|
|
||
| import SwiftProtobuf | ||
|
|
||
| extension Anytype_Event.Membership { | ||
| public struct TiersUpdate: Sendable { | ||
| // SwiftProtobuf.Message conformance is added in an extension below. See the | ||
| // `Message` and `Message+*Additions` files in the SwiftProtobuf library for | ||
| // methods supported on all messages. | ||
|
|
||
| public var tiers: [Anytype_Model_MembershipTierData] = [] | ||
|
|
||
| public var unknownFields = SwiftProtobuf.UnknownStorage() | ||
|
|
||
| public init() {} | ||
| } | ||
| } | ||
|
|
||
| extension Anytype_Event.Membership.TiersUpdate: SwiftProtobuf.Message, SwiftProtobuf._MessageImplementationBase, SwiftProtobuf._ProtoNameProviding { | ||
| public static let protoMessageName: String = Anytype_Event.Membership.protoMessageName + ".TiersUpdate" | ||
| public static let _protobuf_nameMap: SwiftProtobuf._NameMap = [ | ||
| 1: .same(proto: "tiers"), | ||
| ] | ||
|
|
||
| public mutating func decodeMessage<D: SwiftProtobuf.Decoder>(decoder: inout D) throws { | ||
| while let fieldNumber = try decoder.nextFieldNumber() { | ||
| // The use of inline closures is to circumvent an issue where the compiler | ||
| // allocates stack space for every case branch when no optimizations are | ||
| // enabled. https://github.com/apple/swift-protobuf/issues/1034 | ||
| switch fieldNumber { | ||
| case 1: try { try decoder.decodeRepeatedMessageField(value: &self.tiers) }() | ||
| default: break | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public func traverse<V: SwiftProtobuf.Visitor>(visitor: inout V) throws { | ||
| if !self.tiers.isEmpty { | ||
| try visitor.visitRepeatedMessageField(value: self.tiers, fieldNumber: 1) | ||
| } | ||
| try unknownFields.traverse(visitor: &visitor) | ||
| } | ||
|
|
||
| public static func ==(lhs: Anytype_Event.Membership.TiersUpdate, rhs: Anytype_Event.Membership.TiersUpdate) -> Bool { | ||
| if lhs.tiers != rhs.tiers {return false} | ||
| if lhs.unknownFields != rhs.unknownFields {return false} | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| // If the compiler emits an error on this type, it is because this file | ||
| // was generated by a version of the `protoc` Swift plug-in that is | ||
| // incompatible with the version of SwiftProtobuf to which you are linking. | ||
| // Please ensure that you are building against the same version of the API | ||
| // that was used to generate this file. | ||
| fileprivate struct _GeneratedWithProtocGenSwiftVersion: SwiftProtobuf.ProtobufAPIVersionCheck { | ||
| struct _2: SwiftProtobuf.ProtobufAPIVersion_2 {} | ||
| typealias Version = _2 | ||
| } | ||
|
|
||
| // MARK: - Code below here is support for the SwiftProtobuf runtime. | ||
|
|
||
| fileprivate let _protobuf_package = "anytype" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use this on the UI level, it will really affect performance. It's better to make this a published property and discard
@Published private var allTiers: [MembershipTier] = []because seems like it's not used anymore.
Also naming is really ambiguous. We have allTiers and tiers with no significant distinction and ability to understand what is what.