Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey: swap out 2023 survey with 2024 survey #1134

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

sunank200
Copy link
Contributor

@sunank200 sunank200 commented Feb 25, 2025

Swap out the 2023 airflow survey with the 2024 airflow survey.

The following is based on the main branch before this PR:
Screenshot 2025-02-26 at 7 30 00 PM

The following is after the PR changes:
Screenshot 2025-02-26 at 7 45 47 PM

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIIIIICE!

Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rename the file to "Airflow Survey 2024 Results.png"

<button type="submit" class="btn-hollow btn-brown btn-with-icon with-box-shadow">
<span class="bodytext__medium--brownish-grey">View Raw Data</span>
</button>
</a>
</div>
</div>

<div class="past-surveys">
<h3>Past Surveys:</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it a little more, I think we should move these back to the blog. The blog is already where 2019, 2020, and 2022 are and it gives us the benefit of the "survey" tag. We can keep or get rid of this "past surveys" list then as well (or, it can stay, but it should at least have all of them 😄).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to show the screenshots before and after changes, in the description. It would be easier to validate

@sunank200
Copy link
Contributor Author

Is it possible to show the screenshots before and after changes, in the description. It would be easier to validate

The .site.sh build-site, as mentioned in the readme, doesn't work straight. Resolving the errors. I think the commands are outdated.

@potiuk
Copy link
Member

potiuk commented Feb 26, 2025

Is it possible to show the screenshots before and after changes, in the description. It would be easier to validate

The .site.sh build-site, as mentioned in the readme, doesn't work straight. Resolving the errors. I think the commands are outdated.

Oh absolutely - it works with old tooling and environment - we have a task here apache/airflow#45620 created to modernize it. Might be a good opportunity to fix it

@potiuk
Copy link
Member

potiuk commented Feb 26, 2025

Would you like to @sunank200 :) ?

@sunank200
Copy link
Contributor Author

Would you like to @sunank200 :) ?

@potiuk sure

@potiuk
Copy link
Member

potiuk commented Feb 26, 2025

Would you like to @sunank200 :) ?

@potiuk sure

Will assign you then :)

@ephraimbuddy ephraimbuddy merged commit f7f22c1 into apache:main Feb 26, 2025
1 check passed
@sunank200
Copy link
Contributor Author

sunank200 commented Feb 26, 2025

Is it possible to show the screenshots before and after changes, in the description. It would be easier to validate

@phanikumv I ran it locally after changing many scripts. I can create a different PR that fixes the local dev story.

The following is based on the main branch before this PR:
Screenshot 2025-02-26 at 7 30 00 PM

The following is after the PR changes:
Screenshot 2025-02-26 at 7 45 47 PM

Also, I have created the fix for image paths in the 2023 survey in 1135 as this PR was merged early.

@sunank200
Copy link
Contributor Author

Or should we move these back to blog posts, and just add a link to the blog post in the main menu?

Moving the survey to blogs: #1136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants