AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI

[amoghrajesh]

related #42370

Depends on #43783

Migrating the GET Dataset events for DAG runs to fastAPI

Responses:
Legacy

FastAPI

Swagger spec

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[amoghrajesh]

Only the last 3 commits are relevant here

[pierrejeambrun]

The base branch has been merged, branch needs rebasing.

Also you can add the legacy api tag to allow the CI to build.

[pierrejeambrun]

Nice just a couple of comments.

I'll do a final in depth review when the branch is rebased, it will make the review easier to only have the 'definitive' diff and not also the one from the base branch.

[pierrejeambrun]

Thanks, a few suggestions

[pierrejeambrun]

One small suggestion following the change of convention based on Kaxil's PR that was just merged yesterday.

Otherwise looking good and ready to merge.

Thanks

[amoghrajesh]

OK i got a green CI. Is this one good to merge @pierrejeambrun?

[rawwar]

Can we also add a test where there are no assets for an existing dag_id and dag_run_id?

EDIT: probably resolve the comment if that doesn't add any value

[amoghrajesh]

@rawwar that case would become very similar or same like the case where there is no asset found at all. It is covered here https://github.com/apache/airflow/pull/43874/files#diff-2867320a4cbebd99c9a22b52b509dc2a8920137424ed007ce5a5edfbc78fec60R323-R331

[rawwar]

No, It won't raise a 404. Since dag_id and dag_run_id are valid. Should it raise a 404 if no assets are found?