Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.11.1 #44036

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Bump aiohttp to 3.11.1 #44036

merged 1 commit into from
Nov 14, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 14, 2024

aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment)

https://pypi.org/project/aiohttp/3.11.1/


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxil
Copy link
Member Author

kaxil commented Nov 14, 2024

pnuckowski/aioresponses#262 hasn't been merged yet though

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

pnuckowski/aioresponses#262 hasn't been merged yet though

It's unllikely to be merged - the maintainer seems to be MIA for 2 years. That's why likely aiohttp brought back compatiblity with released version of the aioresponses as it is popular

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

looks good. Maybe one nit - would be great to add comment with link to the issue in provider.yaml

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

(we have it in commit so no strictly necessary - but it safes git blame etc.)

@kaxil
Copy link
Member Author

kaxil commented Nov 14, 2024

(we have it in commit so no strictly necessary - but it safes git blame etc.)

Done

@kaxil kaxil merged commit cc7b7a2 into apache:main Nov 14, 2024
108 checks passed
@kaxil kaxil deleted the bump-aiohttp branch November 14, 2024 21:27
@kaxil
Copy link
Member Author

kaxil commented Nov 14, 2024

Damn! last commit msg was used as commit title :(

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

Good we have the comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants