-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix missing logs in UI for tasks in UP_FOR_RETRY state (#54544) #54547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
4aca488 to
c09e533
Compare
c09e533 to
bf742f5
Compare
bf742f5 to
aeec657
Compare
93f848d to
70cbf68
Compare
5d1b900 to
22d2777
Compare
22d2777 to
549e679
Compare
|
let's see what CI says |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but I think other who look at the task logs should take a look. also I think it calls for a unit test.
|
Can you please add unit test @ido177 |
closes: #54544
Fix missing logs in UI for tasks in UP_FOR_RETRY state
Include TaskInstanceState.UP_FOR_RETRY in the log retrieval condition
to ensure logs are shown when a task retries. Previously, tasks that
entered UP_FOR_RETRY had no logs displayed in the UI when using local
log storage.