fix(providers/celery): Migrate conf imports to SDK compatibility layer #60033
+21
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace imports of `from airflow.configuration import conf` with `from airflow.providers.common.compat.sdk import conf` for Airflow 3.x compatibility. Add fallback parameters to conf.get() calls that execute at module import time to prevent AirflowConfigException when config keys are not yet loaded. Part of apache#60000 Signed-off-by: Fouzi Takelait <[email protected]>
sunank200
reviewed
Jan 2, 2026
| ARG_BROKER_API = Arg(("-a", "--broker-api"), help="Broker API") | ||
| ARG_FLOWER_HOSTNAME = Arg( | ||
| ("-H", "--hostname"), | ||
| default=conf.get("celery", "FLOWER_HOST"), |
Collaborator
There was a problem hiding this comment.
Why do we need defaults?
Member
|
Still working on it @ftakelait ? are you going to rebase and fix the comments ? |
Contributor
Author
Hi @potiuk, I am still waiting for @sunank200 to reply about whether I should keep the |
Member
|
I have not seen your question - it's not visible here - I don't think @sunank200 is rather waiting for you - looking at the comments in PR. #60074 (comment) is where we discussed how to fix it - and hopefully it will be fixed there But you can still rebase though and keep on solving conflicts. That would be my recommendation while waiting for mechanism implemented for k8s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
confimports in the Celery provider fromairflow.configurationtoairflow.providers.common.compat.sdkfor Airflow 3.x SDK compatibility.Changes Made
Import Migration (9 files)
celery_executor.pycelery_executor_utils.py(2 imports)celery_kubernetes_executor.pycelery_command.pydefault_celery.pyFallback Parameters Added
Added
fallbackparameters toconf.get()calls that execute at module import time:celery_executor.pyFLOWER_HOST"0.0.0.0"celery_executor.pyFLOWER_PORT5555celery_executor.pyFLOWER_URL_PREFIX""celery_executor.pyFLOWER_BASIC_AUTH""celery_executor.pyDEFAULT_QUEUE"default"celery_executor.pyworker_concurrency16celery_executor.pySYNC_PARALLELISM0celery_executor.pytask_publish_max_retries3celery_executor_utils.pyoperation_timeout1.0celery_executor_utils.pyCELERY_APP_NAME"airflow.executors.celery_executor"default_celery.pySSL_ACTIVEFalseWhy fallbacks are needed?
The SDK
conf.get()is stricter thanairflow.configuration.conf.get()- it raisesAirflowConfigExceptionwhen a key is not found instead of returningNone. This was causing test collection failures when config keys were accessed at module import time before provider configuration was loaded.Part of #60000