Make sqlalchemy an optional dependency for Impala provider #60062
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Srabasti
suggested changes
Jan 3, 2026
Contributor
Srabasti
left a comment
Srabasti
left a comment
There was a problem hiding this comment.
Line 73 should be referencing "sqlalchemy>=1.4.49" instead of "sqlalchemy>=1.4.0".
Happy New Year!
Contributor
Author
|
Updated the minimum SQLAlchemy version to 1.4.49 as suggested. Thanks! |
potiuk
approved these changes
Jan 4, 2026
potiuk
reviewed
Jan 4, 2026
providers/apache/impala/src/airflow/providers/apache/impala/hooks/impala.py
Outdated
Show resolved
Hide resolved
potiuk
reviewed
Jan 5, 2026
providers/apache/impala/src/airflow/providers/apache/impala/hooks/impala.py
Outdated
Show resolved
Hide resolved
potiuk
approved these changes
Jan 5, 2026
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Approve but there is one NIT to take a look.
hohshho
force-pushed
the
fix-impala-sqlalchemy-dep
branch
from
9c29697 to
de578e5
Compare
potiuk
approved these changes
Jan 6, 2026
Prab-27
reviewed
Jan 6, 2026
potiuk
reviewed
Jan 6, 2026
Member
|
One more small nit - after @Prab-27 comment I realized that kerberos one could be fixed as well :) |
Co-authored-by: Jarek Potiuk <[email protected]>
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
) * Make sqlalchemy an optional dependency for Impala provider * Align minimum SQLAlchemy version with Airflow requirements * Refactor ImpalaHook to inline sqlalchemy import logic and update dev dependencies * Use optional dependencies in dev group to avoid version duplication Co-authored-by: Jarek Potiuk <[email protected]> --------- Co-authored-by: Jarek Potiuk <[email protected]>
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
) * Make sqlalchemy an optional dependency for Impala provider * Align minimum SQLAlchemy version with Airflow requirements * Refactor ImpalaHook to inline sqlalchemy import logic and update dev dependencies * Use optional dependencies in dev group to avoid version duplication Co-authored-by: Jarek Potiuk <[email protected]> --------- Co-authored-by: Jarek Potiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #59898
Related: #59895
What does this PR do?
This PR makes
sqlalchemyan optional dependency for the Impala provider.The import in
ImpalaHookis now wrapped in atry/exceptblock, and it raises anAirflowOptionalProviderFeatureExceptionifsqlalchemyis not installed when accessed.Why is this needed?
This aligns the Impala provider with Airflow's standard for task isolation and core dependency removal. By making
sqlalchemyoptional, we ensure that the provider can run in lightweight environments wheresqlalchemyis not strictly required, unless the user explicitly needs features that depend on it (e.g.,get_urior specific SQL connection helpers).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.