60000-keycloak: Update conf imports for keycloak provider #60092
Conversation
boring-cyborg
bot
added
area:dev-tools
area:providers
backport-to-v3-1-test
|
Prek checks run locally with no errors as below |
airflow-core/tests/unit/ti_deps/deps/test_not_previously_skipped_dep.py
Outdated
Show resolved
Hide resolved
|
Do we need to update pyproject.toml since its using airflow/providers/keycloak/pyproject.toml Line 62 in 17fbc9d I'd love to hear your point of view |
Great thinking @prab! As per original PR 60000, snippet below, ONLY if a new import is added to sdk.py that a provider uses, THEN that provider's pyproject.toml needs to be updated. Since no changes are made to sdk.py for keycloak provider, looks to me this is not needed. @sunank200 Your thoughts on this? 
|
You should update it with # use next version -> this feature (common.compat import for conf) has just been added, so you should use "next" version of the common.compat provider (that will be released in the next wave) @Srabasti |
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
requesting changes to not merge it accidentally
|
Incorporated changes for airflow/providers/keycloak/pyproject.toml file : |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 960c2c5 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
* Fix deprecated sqlalchemy usage for test_processor.py * Remove deprecate Query usage and upgrade to SQLAlchemy2.0 * Updating files for test_not_previously_skipped_dep.py * Reverting changes to pyproject.toml files for test_not_previously_skipped_dep.py * Reverting changes to pyproject.toml files for test_not_previously_skipped_dep.py * Reverting changes to pyproject.toml files for test_not_previously_skipped_dep.py * Making changes to test_not_previously_skipped_dep.py * Making changes to pre-committest_not_previously_skipped_dep.py * Making changes to pre-commit-config * Fix pre-commit hook issues hopefully * Update keycloak provider for conf imports * Reverting changes from old PR * pyproject.toml update to use next version
* Fix deprecated sqlalchemy usage for test_processor.py * Remove deprecate Query usage and upgrade to SQLAlchemy2.0 * Updating files for test_not_previously_skipped_dep.py * Reverting changes to pyproject.toml files for test_not_previously_skipped_dep.py * Reverting changes to pyproject.toml files for test_not_previously_skipped_dep.py * Reverting changes to pyproject.toml files for test_not_previously_skipped_dep.py * Making changes to test_not_previously_skipped_dep.py * Making changes to pre-committest_not_previously_skipped_dep.py * Making changes to pre-commit-config * Fix pre-commit hook issues hopefully * Update keycloak provider for conf imports * Reverting changes from old PR * pyproject.toml update to use next version
3 participants
Per [https://github.com//issues/60000],
Update keycloack provider to stop importing conf from airflow.configuration and instead use the shared compat import
from airflow.providers.common.compat.sdk import conf.