-
Notifications
You must be signed in to change notification settings - Fork 16.4k
UI: add task instance summary to DAG cards #60105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Saadmadni84
wants to merge
13
commits into
apache:main
Choose a base branch
from
Saadmadni84:ui-dag-ti-summary
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
42249d3
UI: add task instance summary to DAG cards
Saadmadni84 45136b2
Fix task instance summary rendering during local testing
Saadmadni84 8ba0a24
UI: Render TaskInstanceSummary only when latest run exists
Saadmadni84 cbed370
UI: restore next DAG run info in DagCard
Saadmadni84 771ad16
UI: guard against undefined task instance data
Saadmadni84 6fbe911
Fix lint issue in TaskInstanceSummary
Saadmadni84 804ed04
Add task instance summary stats to UI DAGs endpoint
Saadmadni84 1d456b7
Add backend tests for task_instance_summary aggregation
Saadmadni84 332fb1b
Update OpenAPI and react-query codegens for task_instance_summary
Saadmadni84 0d65739
Fix task_instance_summary query join and improve backend tests
Saadmadni84 a4b8be6
refactor: rename task_instance_summary to latest_run_stats with Lates…
Saadmadni84 066f5ce
Fix mypy type hint and restrict latest_run_stats to latest DagRun
Saadmadni84 9d7a431
Update airflow-core/src/airflow/api_fastapi/core_api/datamodels/ui/da…
Saadmadni84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
airflow-core/src/airflow/ui/src/pages/DagsList/TaskInstanceSummary.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /*! | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { HStack } from "@chakra-ui/react"; | ||
| import { useTranslation } from "react-i18next"; | ||
|
|
||
| import type { LatestRunStats, TaskInstanceState } from "openapi/requests/types.gen"; | ||
| import { Stat } from "src/components/Stat"; | ||
| import { StateBadge } from "src/components/StateBadge"; | ||
|
|
||
| type Props = { | ||
| readonly latestRunStats: LatestRunStats | null | undefined; | ||
| }; | ||
|
|
||
| export const TaskInstanceSummary = ({ latestRunStats }: Props) => { | ||
| const { t: translate } = useTranslation("common"); | ||
|
|
||
| if (!latestRunStats) { | ||
| return null; | ||
| } | ||
|
|
||
| const stateEntries = Object.entries(latestRunStats.task_instance_counts); | ||
|
|
||
| if (stateEntries.length === 0) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <Stat data-testid="task-instance-summary" label={translate("taskInstanceSummary")}> | ||
bbovenzi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <HStack flexWrap="wrap" gap={1}> | ||
| {stateEntries.map(([state, count]) => ( | ||
| <StateBadge key={state} state={state as TaskInstanceState}> | ||
| {count} | ||
| </StateBadge> | ||
| ))} | ||
| </HStack> | ||
bbovenzi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </Stat> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.