-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add meaningful DAG-level documentation to example DAGs #60149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add meaningful DAG-level documentation to example DAGs #60149
Conversation
|
Hi @jroachgolf84 I’ve opened a follow-up PR addressing #60128 with |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is really nice.
providers/standard/src/airflow/providers/standard/example_dags/example_python_decorator.py
Outdated
Show resolved
Hide resolved
|
Also - we strongly recommend installing |
|
Thanks for the reviews and feedback! I’ve addressed the comments and resolved the conversations. Happy to make further adjustments if needed. |
|
Thanks everyone for the reviews! I’ve fixed the doc_md syntax issues flagged by static checks and verified the example DAGs compile cleanly locally. Happy to make any further adjustments if needed. |
Some static check fixes are not applied yet. |
|
Thanks for catching that — much appreciated! I’ve fixed the trailing whitespace / doc_md formatting issues flagged by the static checks and verified locally that all example DAGs compile cleanly. Pushed the fix; CI should be green once checks complete. Please let me know if anything else needs adjustment. |
|
Not green. Are you using |
Srabasti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 54 below in file "providers/standard/src/airflow/providers/standard/example_dags/example_short_circuit_decorator.py", the word run’s (with right single quotation) needs to be replaced with straight quotation (run's).
Short-circuiting affects only the current DAG run’s execution path
Srabasti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 53 below in file "providers/standard/src/airflow/providers/standard/example_dags/example_sensor_decorator.py", the word “run (with right double quotation) needs to be replaced with right straight double quotation ("run).
(for example, “run daily, but only after upstream data is ready”)
Srabasti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 53 below in file "providers/standard/src/airflow/providers/standard/example_dags/example_sensor_decorator.py", the word ready” (with left double quotation) needs to be replaced with left straight double quotation (ready").
(for example, “run daily, but only after upstream data is ready”)
|
Thanks for including the changes @kalel-commits however still static checks checks are failing! As Jarek advised above, have you reproduced locally by running prek run --all-files in your branch? To run prek as part of git workflow, use prek install to set up git hooks.
|
|
@kalel-commits Thanks for the comments! Actually the aim is since a while to rework the examples in general - if you'd like to help and contribute in this topic, that would be also cool! https://cwiki.apache.org/confluence/display/AIRFLOW/Examples+Refurbish |
|
Thanks @jscheffl that sounds great! I wasn’t aware of the broader examples refurbish effort, but it definitely aligns with what motivated this PR. I’d be happy to contribute there as well once this PR is wrapped up. I’ll take a closer look at the Examples Refurbish page and see where I can help next. Thanks for sharing the link! |
|
The same static errors persist, unfortunately. Yes will be great to follow steps as per the documentation link mentioned below, to use WSL/Linux on your Windows machine, so no one has to suggest changes to you. I was in same boat as you and after implementing as per steps in below link, have set up to be able run static checks from my end, before any PR commits. Please feel free to post any blockers in Slack channel #user-troubleshooting, so the community can help out. https://github.com/apache/airflow/blob/main/contributing-docs/03_contributors_quick_start.rst |
|
Thanks for the patience and guidance, @Srabasti. I’ve now set up WSL and prek as recommended, applied the auto-fixes locally, and force-pushed the updated commit. Static checks should be clean now. Please let me know if anything else is needed. |


This PR adds behavior-focused DAG-level documentation (
doc_md) toseveral example DAGs in the standard provider to improve the Docs tab
experience in the Airflow UI.
The documentation explains runtime behavior, design intent, and usage
patterns that are not immediately obvious from the code alone.
This change is documentation-only and does not affect runtime behavior.
Closes: #60128