Skip to content

fix: Remove explicit bg color from active filter buttons #60364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choo121600 wants to merge 1 commit into from
+1 −20
Closed

fix: Remove explicit bg color from active filter buttons #60364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions airflow-core/src/airflow/ui/src/components/DataTable/ToggleTableDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export const ToggleTableDisplay = ({ display, setDisplay }: Props) => {
<ButtonGroup attached colorPalette="brand" pb={2} size="sm" variant="outline">
<IconButton
aria-label={translate("toggleCardView")}
bg={display === "card" ? "colorPalette.muted" : undefined}
onClick={() => setDisplay("card")}
title={translate("toggleCardView")}
variant={display === "card" ? "solid" : "outline"}
Expand All @@ -43,7 +42,6 @@ export const ToggleTableDisplay = ({ display, setDisplay }: Props) => {
</IconButton>
<IconButton
aria-label={translate("toggleTableView")}
bg={display === "table" ? "colorPalette.muted" : undefined}
onClick={() => setDisplay("table")}
title={translate("toggleTableView")}
variant={display === "table" ? "solid" : "outline"}
Expand Down
3 changes: 0 additions & 3 deletions airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/FavoriteFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export const FavoriteFilter = ({ onFavoriteChange, showFavorites }: Props) => {
return (
<ButtonGroup attached size="sm" variant="outline">
<Button
bg={currentValue === "all" ? "colorPalette.muted" : undefined}
colorPalette="brand"
onClick={onFavoriteChange}
value="all"
Expand All @@ -42,7 +41,6 @@ export const FavoriteFilter = ({ onFavoriteChange, showFavorites }: Props) => {
{translate("filters.favorite.all")}
</Button>
<Button
bg={currentValue === "true" ? "colorPalette.muted" : undefined}
colorPalette="brand"
onClick={onFavoriteChange}
value="true"
Expand All @@ -54,7 +52,6 @@ export const FavoriteFilter = ({ onFavoriteChange, showFavorites }: Props) => {
{translate("filters.favorite.favorite")}
</Button>
<Button
bg={currentValue === "false" ? "colorPalette.muted" : undefined}
colorPalette="brand"
onClick={onFavoriteChange}
value="false"
Expand Down
3 changes: 0 additions & 3 deletions airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/PausedFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export const PausedFilter = ({ defaultShowPaused, onPausedChange, showPaused }:
return (
<ButtonGroup attached size="sm" variant="outline">
<Button
bg={currentValue === "all" ? "colorPalette.muted" : undefined}
colorPalette="brand"
onClick={onPausedChange}
value="all"
Expand All @@ -42,7 +41,6 @@ export const PausedFilter = ({ defaultShowPaused, onPausedChange, showPaused }:
{translate("filters.paused.all")}
</Button>
<Button
bg={currentValue === "false" ? "colorPalette.muted" : undefined}
colorPalette="brand"
onClick={onPausedChange}
value="false"
Expand All @@ -51,7 +49,6 @@ export const PausedFilter = ({ defaultShowPaused, onPausedChange, showPaused }:
{translate("filters.paused.active")}
</Button>
<Button
bg={currentValue === "true" ? "colorPalette.muted" : undefined}
colorPalette="brand"
onClick={onPausedChange}
value="true"
Expand Down
13 changes: 1 addition & 12 deletions airflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/StateFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,10 @@ export const StateFilters = ({

return (
<ButtonGroup attached size="sm" variant="outline">
<Button
bg={isAll ? "colorPalette.muted" : undefined}
colorPalette="brand"
onClick={onStateChange}
value="all"
variant={isAll ? "solid" : "outline"}
>
<Button colorPalette="brand" onClick={onStateChange} value="all" variant={isAll ? "solid" : "outline"}>
{translate("dags:filters.paused.all")}
</Button>
<Button
bg={isFailed ? "colorPalette.muted" : undefined}
colorPalette="brand"
data-testid="dags-failed-filter"
onClick={onStateChange}
Expand All @@ -66,7 +59,6 @@ export const StateFilters = ({
{translate("common:states.failed")}
</Button>
<Button
bg={isQueued ? "colorPalette.muted" : undefined}
colorPalette="brand"
data-testid="dags-queued-filter"
onClick={onStateChange}
Expand All @@ -77,7 +69,6 @@ export const StateFilters = ({
{translate("common:states.queued")}
</Button>
<Button
bg={isRunning ? "colorPalette.muted" : undefined}
colorPalette="brand"
data-testid="dags-running-filter"
onClick={onStateChange}
Expand All @@ -88,7 +79,6 @@ export const StateFilters = ({
{translate("common:states.running")}
</Button>
<Button
bg={isSuccess ? "colorPalette.muted" : undefined}
colorPalette="brand"
data-testid="dags-success-filter"
onClick={onStateChange}
Expand All @@ -99,7 +89,6 @@ export const StateFilters = ({
{translate("common:states.success")}
</Button>
<Button
bg={needsReview ? "colorPalette.muted" : undefined}
colorPalette="brand"
data-testid="dags-needs-review-filter"
onClick={onStateChange}
Expand Down
Loading