Fix max_active_tis_per_dag for deferred task instances#61769
Fix max_active_tis_per_dag for deferred task instances#61769SakshamSinghal20 wants to merge 1 commit intoapache:mainfrom
Conversation
Nataneljpwd
left a comment
There was a problem hiding this comment.
Looks good, I will check out the tests soon
|
Just let me know if everything is right or do i need to change anything else? |
|
Hi @jscheffl and @Nataneljpwd! I'm a new contributor and I am very interested in participating in GSoC with this organization this year. I've been reading through the contributing guidelines, but I wanted to ask if there are any specific parts of the codebase you'd recommend I focus on to make a meaningful impact? |
I'd take a look for https://github.com/apache/airflow/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22 |
|
@uranusjr I have changed the state to Active. also let me know if i need to do anything else before the PR gets merged. |
Discussion in Devlist is still ongoing. I think the outcome of this influenced the implementation strategy of this PR. Please do not merge before settled. |
jscheffl
left a comment
There was a problem hiding this comment.
"Request changes" mainly to block merge as long as devlist discussion not finalized
Understood. |
Called for LAZY CONSENSUS in devlist in https://lists.apache.org/thread/qvnfj09qlktmbpdpcsgkbdb8pdmfzm77 Would it be OK to prepare the PR towards this so that in 3 days it is ready to be merged? |
Reset "Request changes" and looking forward for completion!
|
Lazy consensus passed. WOuld it be possible to complete the PR for review by the next 24h? |
|
@SakshamSinghal20 This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
2d0f089 to
1a3fd87
Compare
closes: #61700
Description
Deferred tasks were previously excluded from max_active_tis_per_dag and max_active_tis_per_dagrun concurrency checks. This allowed an unlimited number of tasks to enter the
DEFERREDstate, bypassing configured limits.This PR enforces these limits for
DEFERREDtask instances while ensuring that max_active_tasks (which limits worker slot usage) remains unaffected.Changes:
TASK_CONCURRENCY_EXECUTION_STATESto includeDEFERRED,RUNNING, andQUEUED.dag_run_active_tasks_map.Tests:
Added unit tests covering:
Was generative AI tooling used to co-author this PR?