Fix structlog configuration fails with dict input#62286
Closed
Kabir1618 wants to merge 1 commit intoapache:mainfrom
Closed
Fix structlog configuration fails with dict input#62286Kabir1618 wants to merge 1 commit intoapache:mainfrom
Kabir1618 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Contributor
|
I think there's already a PR for this issue: #62258 |
Author
|
The other PR has failing tests. |
Contributor
@Kabir1618 That doesn't mean that the content is wrong if the maintainer has a problem with it i ll do the necessary changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyErrorwhen stdlib logging passes a single dict argument through structlog (e.g.logging.warning('msg %s', {'a': 10}))LogRecord.__init__unwraps single-dict args into a bare dict, but structlog'sPositionalArgumentsFormatterexpects a tuple and crashes when indexing it_normalize_positional_argsprocessor that re-wraps bare dict args back into a tuple beforePositionalArgumentsFormatterprocesses themCloses #62201
Test plan
TestStdlibDictArgscovering:%swith dict, named%(key)formatting, empty dict, multi-key dict, and normal positional argstest_structlog.pypass (34 existing + 5 new)