Skip to content

Fix structlog JSON serialization crash on non-serializable objects #62656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vamsi-klu wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Fix structlog JSON serialization crash on non-serializable objects #62656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion shared/logging/src/airflow_shared/logging/structlog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,17 @@ def json_dumps(msg, default):
"event": msg.pop("event"),
**msg,
}
return msgspec.json.encode(msg, enc_hook=default)

def safe_default(obj):
"""Fall back to str() if the default enc_hook fails or is None."""
if default is not None:
try:
return default(obj)
except TypeError:
pass
return str(obj)

return msgspec.json.encode(msg, enc_hook=safe_default)

json = structlog.processors.JSONRenderer(serializer=json_dumps)

Expand Down