Improve consistency of values.yaml & misc#64559
Merged
jscheffl merged 11 commits intoapache:mainfrom Apr 3, 2026
Merged
Conversation
Miretpl
requested review from
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
Miretpl
changed the title
jscheffl
approved these changes
Apr 1, 2026
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Wow, impressive rework! Thanks!
jscheffl
added
the
backport-to-chart/v1-2x-test
bugraoz93
approved these changes
Apr 1, 2026
Contributor
bugraoz93
left a comment
bugraoz93
left a comment
There was a problem hiding this comment.
Thanks, Przemysław! Agree with Jens, impressive :D
potiuk
added
the
ready for maintainer review
Miretpl
force-pushed
the
misc
branch
2 times, most recently
from
80fb0c7 to
329bf02
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Helm chart configuration documentation to make values.yaml structure and commenting more consistent, and includes a few small functional/schema tweaks to align defaults and improve generated airflow.cfg formatting.
Changes:
- Reorganized and rewrote many
chart/values.yamlcomments for consistency (descriptions above fields, examples below, standardized deprecation notes). - Tweaked
airflow.cfgrendering in the ConfigMap template to add spacing between sections. - Added a missing
default: nullforworkers.celery.priorityClassNamein the JSON schema.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| chart/values.yaml | Large-scale comment/documentation consistency updates plus a few clarified deprecation notes/examples. |
| chart/values.schema.json | Adds an explicit default for priorityClassName to match chart defaults/intent. |
| chart/templates/configmaps/configmap.yaml | Adjusts whitespace trimming to separate rendered airflow.cfg sections with a blank line. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2026
* Revert comments order to be consistent * Add default value for workers.celery.priorityClassName * Make values.yaml more consistent * New line between sections in config * Captialize some first letters & clean some comments * Fix params & clarify comment * Add missed pdb (cherry picked from commit c707a8a) Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
Backport successfully created: chart/v1-2x-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 3, 2026
…64559) * Revert comments order to be consistent * Add default value for workers.celery.priorityClassName * Make values.yaml more consistent * New line between sections in config * Captialize some first letters & clean some comments * Fix params & clarify comment * Add missed pdb (cherry picked from commit c707a8a) Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
jscheffl
pushed a commit
that referenced
this pull request
Apr 3, 2026
…#64664) * Revert comments order to be consistent * Add default value for workers.celery.priorityClassName * Make values.yaml more consistent * New line between sections in config * Captialize some first letters & clean some comments * Fix params & clarify comment * Add missed pdb (cherry picked from commit c707a8a) Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make Helm's
values.yamlfile more consistent in structure + some comments were rewritten to be clearer for users. After this PR, comments invalues.yamlfile are:Furthermore, the smaller changes were added to this PR, like:
workers.celery.priorityClassNamein thevalues.schema.jsonfileworkers.hostAliasessecurityContextdeprecations + forwebserverSecretAnnotationsWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.