[Subtask]: Use a new configuration item to control whether master & slave mode is enabled. #3846
+43
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lave mode is enabled. apache#3845
…lave mode is enabled. apache#3845
xxubai
reviewed
Nov 21, 2025
Contributor
xxubai
left a comment
xxubai
left a comment
There was a problem hiding this comment.
Thank you for the contribution — this is an important feature.
| .withDescription("The administrator password"); | ||
|
|
||
| /** Enable master & slave mode, which supports horizontal scaling of AMS. */ | ||
| public static final ConfigOption<Boolean> USE_MASTER_SLAVE_MODE = |
Contributor
There was a problem hiding this comment.
I’m wondering whether we could control the single-node and multi-node modes with a configuration option, with the default being the single-node mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new configuration item has been added to control whether master & slave mode is enabled, in order to support the horizontal scaling capability of AMS.
Why are the changes needed?
Close #3845
Brief change log
Add a new configuration USE_MASTER_SLAVE_MODE to control whether master & slave mode is enabled.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation