Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong password during installation makes login impossible #1228

Open
lhui opened this issue Jan 12, 2025 · 8 comments
Open

Wrong password during installation makes login impossible #1228

lhui opened this issue Jan 12, 2025 · 8 comments
Assignees
Labels
enhancement Enhancement request good first issue Good for newcomers
Milestone

Comments

@lhui
Copy link

lhui commented Jan 12, 2025

Is your feature request related to a problem? Please describe

When installing this program, I sometimes accidentally hit wrong keys and enter incorrect passwords. During the installation process, there is no secondary password verification, nor is there an eye icon (👀) that can be clicked to view and confirm the initial password. As a result, if an incorrect password is entered, it becomes impossible to log into the system and the only solution is to reinstall the application.

Describe the solution you'd like

Add an eye icon or add a second password input field for password confirmation, and check/validate this password.

Describe alternatives you've considered

For now, I haven't thought of any other solutions.

current view:

image

preview demo:

image
@lhui lhui added the new-feature New feature request label Jan 12, 2025
@LinkinStars LinkinStars added the good first issue Good for newcomers label Jan 14, 2025
@lhui
Copy link
Author

lhui commented Jan 14, 2025

Can it assign to me?

@lhui
Copy link
Author

lhui commented Jan 16, 2025

Hi @LinkinStars ,

I have implemented the eye icon (👀) feature that allows users to toggle password visibility during the installation process. Please review the changes. Thank you.

@shuashuai shuashuai added this to the v1.4.5 milestone Jan 22, 2025
@hungrybluedev
Copy link

Thanks for this issue and the fix!

I've noticed that this issue remained open despite merging the Pull Request. This is probably because the MR states "Close #1228" instead of "Closes #1228", so this issue wasn't closed automatically by GitHub's regex.

I think it's safe to close this issue!

@fenbox
Copy link
Member

fenbox commented Feb 13, 2025

I do not agree to merge this "eye solution" into the version.

To avoid the issue of entering the wrong password in install page, we can add a password confirmation form.

Image

According to the KANO model, "Add eye solution" is an unimportant feature. Adding it may cause some potential problems, including conflicts with certain browsers or plugins.

@fenbox fenbox added enhancement Enhancement request and removed new-feature New feature request labels Feb 13, 2025
@shuashuai
Copy link
Member

I do not agree to merge this "eye solution" into the version.

To avoid the issue of entering the wrong password in install page, we can add a password confirmation form.

According to the KANO model, "Add eye solution" is an unimportant feature. Adding it may cause some potential problems, including conflicts with certain browsers or plugins.

@lhui

Based on the above reasons, I have revoked the PR submission of the original plan. If you are still interested, you can use the method of adding repeated input to achieve the effect of confirming the password.

@fenbox fenbox changed the title add eye button for check password when install the app Wrong password during installation makes login impossible Feb 14, 2025
@CodexX777
Copy link

Can you assign this issue to me?

@CodexX777
Copy link

I noticed that translation is not working for some fields, in this fix also I have just updated the en_US.yaml, do we have any strategy to fix this, since I guess crowdin wont be helpful for such frequent changes. Any insights would be helpful

@sy-records
Copy link
Member

Translations are synchronized at release time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

7 participants