Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add password hide show logic for init server #1234

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

lhui
Copy link

@lhui lhui commented Jan 15, 2025

Hi team,

I have implemented the eye icon (👀) feature that allows users to toggle password visibility during the installation process. Please review the changes. Thank you.

Close #1228

@LinkinStars LinkinStars requested a review from shuashuai January 16, 2025 02:24
@lhui
Copy link
Author

lhui commented Jan 18, 2025

Hi @shuashuai I will try to fix above. thanks.

@lhui
Copy link
Author

lhui commented Jan 20, 2025

Hi @shuashuai I have refactored and tested the above code. Please review the changes. Thank you.

Copy link
Member

@shuashuai shuashuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shuashuai shuashuai added this to the v1.4.5 milestone Jan 22, 2025
@shuashuai shuashuai merged commit f8bef82 into apache:dev Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants