fix: Limit unanswered question query to available questions #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sy-records
force-pushed
the
fix/unanswered
branch
from
e233d24 to
2028c95
Compare
LinkinStars
requested changes
Mar 4, 2025
| @@ -417,6 +417,7 @@ func (qr *questionRepo) GetQuestionPage(ctx context.Context, page, pageSize int, | |||
| session.OrderBy("question.pin desc,question.vote_count DESC, question.view_count DESC") | |||
| case "unanswered": | |||
| session.Where("question.answer_count = 0") | |||
| session.And("question.status = ?", entity.QuestionStatusAvailable) | |||
There was a problem hiding this comment.
The session.In("question.status", status) may conflict with session.And("question.status = ?", entity.QuestionStatusAvailable)
LinkinStars
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1268