docs: refine command usage statements #1331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codes are self-documenting enough.
Octobug
force-pushed
the
docs/cmd-usage-statements
branch
2 times, most recently
from
03dd901 to
cf49b11
Compare
Octobug
changed the title
Octobug
force-pushed
the
docs/cmd-usage-statements
branch
from
cf49b11 to
636d410
Compare
LinkinStars
requested changes
May 9, 2025
cmd/command.go
Outdated
| @@ -68,7 +68,7 @@ func init() { | |||
|
|
|||
| buildCmd.Flags().StringVarP(&buildDir, "build-dir", "b", "", "dir for build process") | |||
|
|
|||
| upgradeCmd.Flags().StringVarP(&upgradeVersion, "from", "f", "", "upgrade from specific version, eg: -f v1.1.0") | |||
| upgradeCmd.Flags().StringVarP(&upgradeVersion, "from", "f", "", "upgrade to the specific version from your input, eg: -f v1.1.0") | |||
There was a problem hiding this comment.
There is a slight misunderstanding in the description of the upgrade command here. For example, if the command is answer upgrade -f v1.3.5, it means that answer will be upgraded from v1.3.5 to the latest version(The current version of the binary). So it's not you describing an upgrade to a specified version.
There was a problem hiding this comment.
Oh...Okay, actually I especially checked how the upgradeVersion var was used. It turns out that I misunderstood this comment line and the function signature... 😂 I'll recover its description.
Line 48 in 3f1ed50
answer/internal/migrations/migrations.go
Line 137 in 636d410
Octobug
force-pushed
the
docs/cmd-usage-statements
branch
from
636d410 to
405f794
Compare
Octobug
force-pushed
the
docs/cmd-usage-statements
branch
from
405f794 to
75c5c89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1330 for backgroud details.