Skip to content

Conversation

@dvarrazzo
Copy link

Not all the resources handle fullnameOverride consistently. Most of them just use the release name.

In the following example, whatever should appear in no resource name:

$ helm template whatever --set fullnameOverride=foo ./charts/apisix-ingress-controller | yq --no-doc '.metadata.name + "/" + .kind'
whatever/ServiceAccount
whatever-ingress-config/ConfigMap
whatever-apisix-ingress-manager-role/ClusterRole
whatever-apisix-ingress-metrics-auth-role/ClusterRole
whatever-apisix-ingress-metrics-reader/ClusterRole
whatever-apisix-ingress-manager-rolebinding/ClusterRoleBinding
whatever-apisix-ingress-metrics-auth-rolebinding/ClusterRoleBinding
whatever-apisix-ingress-leader-election-role/Role
whatever-apisix-ingress-leader-election-rolebinding/RoleBinding
foo/Service
foo/Deployment
apisix/IngressClass

after the fix:

$ helm template whatever --set fullnameOverride=foo ./charts/apisix-ingress-controller | yq --no-doc '.metadata.name + "/" + .kind'
foo/ServiceAccount
foo-ingress-config/ConfigMap
foo-manager-role/ClusterRole
foo-metrics-auth-role/ClusterRole
foo-metrics-reader/ClusterRole
foo-manager-rolebinding/ClusterRoleBinding
foo-metrics-auth-rolebinding/ClusterRoleBinding
foo-leader-election-role/Role
foo-leader-election-rolebinding/RoleBinding
foo/Service
foo/Deployment
apisix/IngressClass

The MR also remove the redundant apisix-ingress part from the roles and bindings (previous names would have been like apisix-ingress-controller-apisix-ingress-manager-role) and fixes the volume names in the deployment.

Daniele Varrazzo added 2 commits August 21, 2025 16:10
It doesn't need to be prefixed by the release name because the volume
names are local to the deployment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants