Skip to content

Conversation

@sihyeonn
Copy link

Description

This PR fixes a build failure when running make build-on-debian-dev.

The debian-dev image build failed at:

[2/2] STEP 9/21: COPY --chown=nobody:root ui/ /usr/local/apisix/ui/
Error: building at STEP "COPY --chown=nobody:root ui/ /usr/local/apisix/ui/": checking on sources under "/var/tmp/libpod_builder971763380/build": copier: stat: "/ui": no such file or directorybecause the ui directory does not exist in the build context.

To resolve this, the build script now ensures that an (empty) ui directory is created before building the debian-dev image, so the COPY ui/ /usr/local/apisix/ui/ step always succeeds even when no UI assets are present.

Which issue(s) this PR fixes:

Fixes #

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 18, 2025
@Baoyuantop
Copy link
Contributor

Hi @sihyeonn, you can merge the latest main branch to make CI pass.

@sihyeonn
Copy link
Author

Hi @sihyeonn, you can merge the latest main branch to make CI pass.

Thank you for your review! But I still need 2 more reviews to merge 🥲 Merging is blocked!

@Baoyuantop
Copy link
Contributor

The failed test appears to be unrelated to this change and has already been fixed in the main branch.

Copy link
Member

@SkyeYoung SkyeYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 What you're doing is feasible, but currently, the debian-dev build is used like this: https://github.com/apache/apisix/blob/master/.github/workflows/push-dev-image-on-commit.yml#L37-L54

So I think, you might as well move the part of building the UI directly into the Makefile.

Or is your idea that you don’t want a UI?

@SkyeYoung SkyeYoung requested a review from bzp2010 November 21, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants