-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dev): Use Miniforge instead of Mambaforge #2211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Not sure how to reconcile
with
|
Ah, this is a known problem. Could you pin |
That did indeed solve that problem. There are three more failures (so far). Two of them seem to be because R isn't installed, and I can't tell what's supposed to be doing that. |
I just looked for that error briefly and couldn't find it...which job is it on?
Here, I think: ...but not sure why this change would cause that to stop working. |
In "Verification (Nightly) / Verify Source (Conda)/macos-13 (pull_request)", for instance, at nearly the end of the log: EDIT: Does "r-testthat" include both R and the "testthat" framework? |
It does! There seem to be a very long list of conflicts when installing the R dependencies, which I think is something about https://github.com/apache/arrow-adbc/actions/runs/11137066683/job/30949901931?pr=2211#step:5:30453 It seems like pinning gobject may have introduced this? (I don't see those conflicts in the run before that pin) |
It's possible. I tried just the pinning change in #2213, but that didn't trigger the verification runs that are failing with the R error. |
Hmm...I also can't trigger strictly based on the pin (although I know our conda env has a lot of stuff). # docker run --rm -it condaforge/miniforge3
conda create -n foofy
conda install glib=2.80.5 compilers libsqlite libpq pkg-config r-testthat If you want to skip the R part and open a separate issue I can plug away at that before the next release...getting CI to pass for everybody else is a far more pressing concern (we run separate R checks using environments more likely to show up for a user in CI). |
Raúl has opened a separate issue (#2217) as it turns out that the R part is already failing without this Miniforge change. As such, I'm going to check this in. |
Use Miniforge instead of Mambaforge, as the latter has been deprecated.
Closes #2206