fix(csharp/src/Drivers/Apache): fix to workaround concurrency issue #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birschick-bq
requested review from
lidavidm and
CurtHagenlocher
as code owners
CurtHagenlocher
requested changes
Oct 29, 2024
| @@ -30,8 +30,12 @@ namespace Apache.Arrow.Adbc.Tests.Drivers.Apache.Spark | |||
| /// <remarks> | |||
| /// Tests are ordered to ensure data is created for the other | |||
| /// queries to run. | |||
| /// <para>Note: This test create/replaces the table identified in the configuration (metadata/table). | |||
| @@ -30,8 +30,12 @@ namespace Apache.Arrow.Adbc.Tests.Drivers.Apache.Spark | |||
| /// <remarks> | |||
| /// Tests are ordered to ensure data is created for the other | |||
| /// queries to run. | |||
| /// <para>Note: This test create/replaces the table identified in the configuration (metadata/table). | |||
| /// It uses the test collection "TableCreateTestCollection" to ensure it does not run | |||
| /// as the same time as any other tests that may create/udate the same table.</para> | |||
| @@ -36,8 +36,12 @@ namespace Apache.Arrow.Adbc.Tests.Drivers.Apache.Spark | |||
| /// <remarks> | |||
| /// Tests are ordered to ensure data is created for the other | |||
| /// queries to run. | |||
| /// <para>Note: This test create/replaces the table identified in the configuration (metadata/table). | |||
| @@ -36,8 +36,12 @@ namespace Apache.Arrow.Adbc.Tests.Drivers.Apache.Spark | |||
| /// <remarks> | |||
| /// Tests are ordered to ensure data is created for the other | |||
| /// queries to run. | |||
| /// <para>Note: This test create/replaces the table identified in the configuration (metadata/table). | |||
| /// It uses the test collection "TableCreateTestCollection" to ensure it does not run | |||
| /// as the same time as any other tests that may create/udate the same table.</para> | |||
birschick-bq
changed the title
CurtHagenlocher
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an interim work-around for the concurrency issue identified in #2280.
DELETEstatements from the SQL table scripts.HttpRequestTimeoutdue to an incomplete implementation of theValidateOptionsinSparkDatabricksConnection.CREATE OR REPLACE TABLEto reduce probably of inconsistent state.Note: this is not the final solution. A more robust isolation of table creation needs to done to isolate concurrency.