feat(csharp/src/Drivers/Databricks): Added decimalColumnScale connection param #3473
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msrathore-db
changed the title
msrathore-db
changed the title
jadewang-db
reviewed
Sep 24, 2025
| /// <summary> | ||
| /// Gets the decimal column scale value. | ||
| /// </summary> | ||
| public int DecimalColumnScale => _decimalColumnScale; |
There was a problem hiding this comment.
where will this being used?
There was a problem hiding this comment.
As explained in the jira, this param was not actually being used in ODBC and simba JDBC either since thrift already provides a default scale of 0.
I'll run test on different spark versions to see any changes.
Once confirmed for the other DBR versions, I can complete this PR.
CurtHagenlocher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a connection param of DecimalColumnScale. The parameter is not used in the code since the thrift server gives the default scale to the DECIMAL columns already. The default value provided is 0. So this function does not override it.
PECO-2733