GH-37842: [R] Implement infer_schema.data.frame() #37843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: R
awaiting committer review
paleolimbot
reviewed
Sep 27, 2023
r/R/schema.R
Outdated
| @@ -285,6 +285,9 @@ infer_schema.Dataset <- function(x) x$schema | |||
| #' @export | |||
| infer_schema.arrow_dplyr_query <- function(x) implicit_schema(x) | |||
|
|
|||
| #' @export | |||
| infer_schema.data.frame <- function(x) infer_schema(arrow_table(x)) | |||
There was a problem hiding this comment.
arrow_table(some_data_frame) is potentially a very expensive operation (possibly requiring a full copy of the data if, for example, they are all string columns).
Another option is infer_schema(arrow_table(x[integer(), , drop = FALSE])), although this won't quite work for things like list() columns where we actually need some values to properly infer the type.
Unless I'm missing some prior art in the package, I think schema(!!! lapply(x, infer_type)) might be the way to go.
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
paleolimbot
reviewed
Sep 27, 2023
r/tests/testthat/test-schema.R
Outdated
| @@ -300,6 +300,9 @@ test_that("schema extraction", { | |||
| expect_equal(schema(example_data), tbl$schema) | |||
| expect_equal(schema(tbl), tbl$schema) | |||
|
|
|||
| expect_equal(schema(data.frame(a = 1, a = "x")), schema(a = double(), a.1 = string())) | |||
There was a problem hiding this comment.
Suggested change
| expect_equal(schema(data.frame(a = 1, a = "x")), schema(a = double(), a.1 = string())) | |
| expect_equal(schema(data.frame(a = 1, a = "x", check.names = FALSE)), schema(a = double(), a = string())) |
(This might error and that's OK too, can just be expect_error())
There was a problem hiding this comment.
Good shout, that actually captures the true nature of what you're wanting to test there!
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 79abb73. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
### Rationale for this change
Users will be able to easily see the schema which their `data.frame` object will have when it's converted into an Arrwo table.
### What changes are included in this PR?
Implements `infer_schema()` method for `data.frame` objects.
Before:
``` r
library(arrow)
schema(mtcars)
#> Error in UseMethod("infer_schema"): no applicable method for 'infer_schema' applied to an object of class "data.frame"
```
After:
``` r
library(arrow)
schema(mtcars)
#> Schema
#> mpg: double
#> cyl: double
#> disp: double
#> hp: double
#> drat: double
#> wt: double
#> qsec: double
#> vs: double
#> am: double
#> gear: double
#> carb: double
#>
#> See $metadata for additional Schema metadata
```
### Are these changes tested?
Yes
### Are there any user-facing changes?
Yes
* Closes: apache#37842
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
### Rationale for this change
Users will be able to easily see the schema which their `data.frame` object will have when it's converted into an Arrwo table.
### What changes are included in this PR?
Implements `infer_schema()` method for `data.frame` objects.
Before:
``` r
library(arrow)
schema(mtcars)
#> Error in UseMethod("infer_schema"): no applicable method for 'infer_schema' applied to an object of class "data.frame"
```
After:
``` r
library(arrow)
schema(mtcars)
#> Schema
#> mpg: double
#> cyl: double
#> disp: double
#> hp: double
#> drat: double
#> wt: double
#> qsec: double
#> vs: double
#> am: double
#> gear: double
#> carb: double
#>
#> See $metadata for additional Schema metadata
```
### Are these changes tested?
Yes
### Are there any user-facing changes?
Yes
* Closes: apache#37842
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change
Users will be able to easily see the schema which their `data.frame` object will have when it's converted into an Arrwo table.
### What changes are included in this PR?
Implements `infer_schema()` method for `data.frame` objects.
Before:
``` r
library(arrow)
schema(mtcars)
#> Error in UseMethod("infer_schema"): no applicable method for 'infer_schema' applied to an object of class "data.frame"
```
After:
``` r
library(arrow)
schema(mtcars)
#> Schema
#> mpg: double
#> cyl: double
#> disp: double
#> hp: double
#> drat: double
#> wt: double
#> qsec: double
#> vs: double
#> am: double
#> gear: double
#> carb: double
#>
#> See $metadata for additional Schema metadata
```
### Are these changes tested?
Yes
### Are there any user-facing changes?
Yes
* Closes: apache#37842
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change
Users will be able to easily see the schema which their `data.frame` object will have when it's converted into an Arrwo table.
### What changes are included in this PR?
Implements `infer_schema()` method for `data.frame` objects.
Before:
``` r
library(arrow)
schema(mtcars)
#> Error in UseMethod("infer_schema"): no applicable method for 'infer_schema' applied to an object of class "data.frame"
```
After:
``` r
library(arrow)
schema(mtcars)
#> Schema
#> mpg: double
#> cyl: double
#> disp: double
#> hp: double
#> drat: double
#> wt: double
#> qsec: double
#> vs: double
#> am: double
#> gear: double
#> carb: double
#>
#> See $metadata for additional Schema metadata
```
### Are these changes tested?
Yes
### Are there any user-facing changes?
Yes
* Closes: apache#37842
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Users will be able to easily see the schema which their
data.frameobject will have when it's converted into an Arrwo table.What changes are included in this PR?
Implements
infer_schema()method fordata.frameobjects.Before:
After:
Are these changes tested?
Yes
Are there any user-facing changes?
Yes
infer_schema.data.frame()#37842