GH-37893: [Java] Move Types.proto in a subfolder #37894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project. Move Types.proto into gandiva/types.proto (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.
|
|
github-actions
bot
added
awaiting changes
Fix cmakefile line length issue
github-actions
bot
added
awaiting change review
Fix types.pb.h protobuf include directives
|
Looks like I missed a couple of things (I was trying to go directly to PR since I had some build environment issues on my new laptop). Moving to draft and solving things locally first so that reviewers do not waste too much time. |
Fix gandiva protobuf namespacing
|
I believe this PR is ready for review again |
lidavidm
approved these changes
Sep 28, 2023
etseidl
pushed a commit
to etseidl/arrow
that referenced
this pull request
Sep 28, 2023
### Rationale for this change Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project. ### What changes are included in this PR? Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict. ### Are these changes tested? Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive. ### Are there any user-facing changes? No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive. **This PR includes breaking changes to public APIs.** * Closes: apache#37893 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 019d06d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
### Rationale for this change Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project. ### What changes are included in this PR? Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict. ### Are these changes tested? Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive. ### Are there any user-facing changes? No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive. **This PR includes breaking changes to public APIs.** * Closes: apache#37893 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
### Rationale for this change Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project. ### What changes are included in this PR? Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict. ### Are these changes tested? Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive. ### Are there any user-facing changes? No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive. **This PR includes breaking changes to public APIs.** * Closes: apache#37893 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project. ### What changes are included in this PR? Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict. ### Are these changes tested? Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive. ### Are there any user-facing changes? No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive. **This PR includes breaking changes to public APIs.** * Closes: apache#37893 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project. ### What changes are included in this PR? Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict. ### Are these changes tested? Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive. ### Are there any user-facing changes? No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive. **This PR includes breaking changes to public APIs.** * Closes: apache#37893 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.
What changes are included in this PR?
Move
Types.protointogandiva/types.proto(also matching convention of using lowercase filename) so that it become less likely to cause a conflict.Are these changes tested?
Change should have no impact on the feature itself. Manually check the resulting jar to confirm that
types.protois not located at the root of the archive.Are there any user-facing changes?
No user-facing. Developers who were actually referencing Gandiva
Types.protoin their project may have to change theirimportdirective.This PR includes breaking changes to public APIs.