GH-26818: [C++][Python] Preserve order when writing dataset multi-threaded #44470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: Python
awaiting review
EnricoMi
force-pushed
the
preserve-order-2
branch
2 times, most recently
from
9ca8c76
to
28cb588
Compare
|
This pull request seems to functionally overlap with this one. Some changes are almost exactly the same. Ordering of data is kept in threaded execution with use of batch index. Can you check whether it fixes your use case also? |
EnricoMi
force-pushed
the
preserve-order-2
branch
from
28cb588
to
0377ef9
Compare
EnricoMi
commented
Oct 31, 2024
| @@ -103,8 +103,8 @@ class ARROW_ACERO_EXPORT SourceNodeOptions : public ExecNodeOptions { | |||
| std::shared_ptr<Schema> output_schema; | |||
| /// \brief an asynchronous stream of batches ending with std::nullopt | |||
| std::function<Future<std::optional<ExecBatch>>()> generator; | |||
|
|
|||
| Ordering ordering = Ordering::Unordered(); | |||
There was a problem hiding this comment.
The constructor has a default value for ordering and initializes ordering with the value given to the constructor. No point for another default value here, I think.
github-actions
bot
added
awaiting committer review
EnricoMi
force-pushed
the
preserve-order-2
branch
from
2776b34
to
6024066
Compare
gitmodimo
reviewed
Oct 31, 2024
| acero::ConsumingSinkNodeOptions{ | ||
| std::move(consumer), | ||
| {}, | ||
| /*sequence_output=*/write_options.preserve_order})); |
|
Since you are fixing dataset write ordering I think this check never fires. It should be moved to InsertBatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The order of rows in a dataset might be important for users and should be preserved when writing to a filesystem. With multi-threaded write, the order is currently not guaranteed,
What changes are included in this PR?
Preserving the dataset order of rows requires the
SourceNodeto useImplicitOrdering(this gives exec batches an index), and theConsumingSinkNodeto sequence exec batches (preserve order of batches by their index).User-facing changes:
preserve_ordertoFileSystemDatasetWriteOptionsDev-facing changes:
orderingtoSourceNodeOptionsimplicit_orderingtoScanNodeOptionsDefault behaviour is current behaviour.
Are these changes tested?
Unit tests have been added,
Are there any user-facing changes?
Users can set
FileSystemDatasetWriteOptions.preserve_order = true(C++) /arrow.dataset.write_dataset(..., preserve_order=True)(Python).