Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44629: [C++][Acero] Use implicit_ordering for asof_join rather than require_sequenced_output #44616

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EnricoMi
Copy link
Contributor

@EnricoMi EnricoMi commented Nov 1, 2024

Rationale for this change

Changes in #44083 (GH-41706) unnecessarily sequences batches retrieved from scanner where it only requires the batches to provide index according to implicit input order.

What changes are included in this PR?

Setting implicit_ordering causes existing code to set batch index, which is then available to the asof_join node to sequence the batches int input order. This replaces some of #44083 changes.

Some code introduced by #44083 turns out to not be required and has therefore been reverted.

Are these changes tested?

Existing unit tests still pass.

Are there any user-facing changes?

Reverts some breaking user-facing changes done by #44083.

Copy link

@gitmodimo gitmodimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I think all source nodes need an option to assert Implicit ordering but I am not sure if it is in the scope of this PR.
Is there currently any use for require_sequenced_output?

@EnricoMi
Copy link
Contributor Author

EnricoMi commented Nov 1, 2024

@westonpace are you happy with this?

@kou
Copy link
Member

kou commented Nov 2, 2024

Could you open a new issue instead of reusing closed issue?

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 2, 2024
@EnricoMi EnricoMi changed the title GH-41706: [C++][Acero][Followup] Use implicit_ordering for asof_join rather than require_sequenced_output GH-44629: [C++][Acero] Use implicit_ordering for asof_join rather than require_sequenced_output Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

⚠️ GitHub issue #44629 has been automatically assigned in GitHub to PR creator.

@EnricoMi
Copy link
Contributor Author

EnricoMi commented Nov 3, 2024

@kou done

@rok rok requested a review from felipecrv November 7, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants