GH-44651: [Python] Allow from_buffers to work with StringView on Python #44701
+57
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Python
awaiting committer review
raulcd
commented
Nov 12, 2024
github-actions
bot
added
awaiting changes
pitrou
reviewed
Nov 12, 2024
github-actions
bot
added
awaiting change review
raulcd
added
awaiting change review
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting changes
raulcd
added
awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently
from_buffersis not working with StringView on Python because we validate against num_buffers. This only take into account the mandatory buffers but does not take into account the variadic_spec that can be present for both string_view and binary_viewWhat changes are included in this PR?
Take into account whether the type contains a variadic_spec for the non-mandatory buffers and only check lower_bound number of buffers.
Are these changes tested?
Yes, I've added a couple of tests.
Are there any user-facing changes?
We are exposing a new method on the Python DataType.
has_variadic_bufferswhich tells us whether the number of buffers expected is only lower-bounded by num_buffers.