-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44703: [CI][MATLAB][Packaging] Update MATLAB CI and crossbow
packaging workflows to build against MATLAB R2024b
#44704
base: main
Are you sure you want to change the base?
Conversation
@github-actions crossbow submit matlab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just make sure the crossbow job runs successfully before merigng.
Revision: 5fca60d Submitted crossbow builds: ursacomputing/crossbow @ actions-11d1a5204d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the new matlab version creates a different mtlbx name:
matlab-arrow-19.0.0.mltbx
but we are looking for matlab-arrow-19.0.0.dev66.mltbx [PENDING]
You can either update the artifact name in tasks.yml
or do it on the matlab side.
Thanks, @assignUser! I'll make the required change. |
@github-actions crossbow submit matlab |
Revision: c9c3622 Submitted crossbow builds: ursacomputing/crossbow @ actions-6ab43281e8
|
@assignUser - we updated the Just to clarify - this means the name of the MLTBX file will never include an RC version or a Thank you! |
If we use How about adding a new variable for diff --git a/dev/archery/archery/crossbow/core.py b/dev/archery/archery/crossbow/core.py
index 12571c0ff6..ea6ba31fb8 100644
--- a/dev/archery/archery/crossbow/core.py
+++ b/dev/archery/archery/crossbow/core.py
@@ -803,6 +803,11 @@ class Target(Serializable):
self.r_version = r_version
self.no_rc_version = re.sub(r'-rc\d+\Z', '', version)
self.no_rc_r_version = re.sub(r'-rc\d+\Z', '', r_version)
+ # Example:
+ #
+ # '19.0.0.dev66' ->
+ # '19.0.0'
+ self.no_rc_no_dev_version = (r'\.dev\d+\Z', '', self.no_rc_version)
# Semantic Versioning 1.0.0: https://semver.org/spec/v1.0.0.html
#
# > A pre-release version number MAY be denoted by appending an
@@ -1195,6 +1200,7 @@ class Job(Serializable):
versions = {
'version': target.version,
'no_rc_version': target.no_rc_version,
+ 'no_rc_no_dev_version': target.no_rc_version,
'no_rc_semver_version': target.no_rc_semver_version,
'no_rc_snapshot_version': target.no_rc_snapshot_version,
'r_version': target.r_version,
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 31d260bbfd..12dcfc1edd 100644
--- a/dev/tasks/tasks.yml
+++ b/dev/tasks/tasks.yml
@@ -693,7 +693,7 @@ tasks:
ci: github
template: matlab/github.yml
artifacts:
- - matlab-arrow-{no_rc_version}.mltbx
+ - matlab-arrow-{no_rc_no_dev_version}.mltbx
############################## Arrow JAR's ##################################
|
@kou - thank you. That's an excellent point and a helpful suggestion. I'll make this change. |
@github-actions crossbow submit matlab |
|
@kou - I've added Is there any way I can qualify the changes to crossbow using the bot on this PR? If not, would it make sense to open a separate PR to just to make the changes to |
I just noticed that @raulcd ran into the exact same issue when qualifying his changes for |
I tried setting up my own fork to test the
If possible, could someone point me towards the steps required to configure a working OAuth access token for the Thanks! |
Rationale for this change
MATLAB R2024b is now available for use with the matlab-actions/setup-matlab GitHub Action.
We should update the matlab.yml CI workflow, as well as the crossbow packaging workflows for the MATLAB MLTBX files to build against R2024b.
What changes are included in this PR?
.github/workflows/matlab.yml
CI workflow file to build the MATLAB Interface against MATLAB R2024b.dev/tasks/matlab/github.yml
crossbow
packaging workflow to build the MATLAB MLTBX files against MATLAB R2024b.mathworks/libmexclass
version to commit cac7c3630a086bd5ba41413af44c833cef189c09 to work aroundlibmexclass_client_add_proxy_library
should link the client proxy library against thelibmex
shared library mathworks/libmexclass#92Are these changes tested?
Yes.
mathworks/arrow
.Are there any user-facing changes?
Yes.
Notes
crossbow
packaging workflows to build against MATLABR2024b
#44703