GH-43135: [R] Change the binary type mapping to blob::blob
#45595
+20
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eitsupi
force-pushed
the
r-blob-support
branch
from
4e58234 to
8e8dac3
Compare
Signed-off-by: SHIMA Tatsuya <[email protected]>
eitsupi
force-pushed
the
r-blob-support
branch
from
8e8dac3 to
1811175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Many packages, including
nanoarrow, use theblobclass provided by theblobpackage to represent a vector of binary data.However, this package did not use
blob.Therefore, when this package convert Arrow Binary type to R, it was difficult for other packages to interpret it as a Binary type.
What changes are included in this PR?
The current special processing for the
arrow_binaryclass should also be performed for theblobclass.Also,
arrow_binary,arrow_large_binary, andarrow_fixed_size_binarywill be changed to subclasses of theblobclass.Are these changes tested?
Rewrote some existing tests to use
blobinstead ofarrow_binary.Are there any user-facing changes?
Yes.
But the traditional classes have been changed to subclasses of
blob, so little impact is expected.blob::blob#43135