-
Notifications
You must be signed in to change notification settings - Fork 3.8k
GH-43135: [R] Change the binary type mapping to blob::blob
#45595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
8e8dac3
to
1811175
Compare
@paleolimbot @assignUser Does one of you want to take a look? |
Sounds like a good idea to improve compatibility with the larger ecosystem. Especially if nanoarrow already does it. Not sure if there were reasons to not implement this historically @jonkeane @thisisnic ? |
+1! I am not aware of a practical reason to differentiate between fixed size/large/regular binary at the R level (which seems to be the reason noted in the issue thread) but perhaps others will add that context. |
Signed-off-by: SHIMA Tatsuya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this
Can anyone merge this? Thanks! |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 713d09b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Many packages, including
nanoarrow
, use theblob
class provided by theblob
package to represent a vector of binary data.However, this package did not use
blob
.Therefore, when this package convert Arrow Binary type to R, it was difficult for other packages to interpret it as a Binary type.
What changes are included in this PR?
The current special processing for the
arrow_binary
class should also be performed for theblob
class.Also,
arrow_binary
,arrow_large_binary
, andarrow_fixed_size_binary
will be changed to subclasses of theblob
class.Are these changes tested?
Rewrote some existing tests to use
blob
instead ofarrow_binary
.Are there any user-facing changes?
Yes.
But the traditional classes have been changed to subclasses of
blob
, so little impact is expected.blob::blob
#43135