GH-46584: [C++][FlightRPC] Iterate over endpoints in ODBC driver #47991
+370
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
force-pushed
the
gh-46584-iterate-endpoint
branch
from
64e84f5 to
488ff8e
Compare
lidavidm
changed the title
lidavidm
reviewed
Oct 31, 2025
cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_stream_chunk_buffer.h
Outdated
Show resolved
Hide resolved
Comment on lines
95
to
104
| void VerifyArraysContainIntsOnly(std::shared_ptr<Array> intArray) { | ||
| for (int64_t i = 0; i < intArray->length(); ++i) { | ||
| // null values are accepted | ||
| if (!intArray->IsNull(i)) { | ||
| auto scalar_data = intArray->GetScalar(i).ValueOrDie(); | ||
| std::string scalar_str = ConvertToJson(*scalar_data); | ||
| ASSERT_TRUE(std::all_of(scalar_str.begin(), scalar_str.end(), ::isdigit)); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Can't you just check the array type?
| std::unique_ptr<FlightClient> temp_flight_client; | ||
| util::ThrowIfNotOK(FlightClient::Connect(endpoint_locations[0], client_options) | ||
| .Value(&temp_flight_client)); | ||
| temp_flight_sql_client.reset(new FlightSqlClient(std::move(temp_flight_client))); |
Comment on lines
+68
to
+75
| return boost::make_optional( | ||
| is_not_ok || is_not_empty, | ||
| std::make_pair(std::move(result), temp_flight_sql_client)); |
Contributor
Author
There was a problem hiding this comment.
Since boost-optional is blocking the MSVC CI (for some reason it doesn't block my local MSVC build), I will remove boost-optional in #48067
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Contributor
|
@lidavidm Please take another look. |
justing-bq
force-pushed
the
gh-46584-iterate-endpoint
branch
from
4d34c4c to
4da0d4a
Compare
lidavidm
approved these changes
Nov 14, 2025
|
|
||
| using arrow::internal::checked_pointer_cast; | ||
| using std::nullopt; | ||
| using std::optional; |
Member
There was a problem hiding this comment.
not necessarily a blocker here but generally I think we avoid using types from std.
github-actions
bot
added
awaiting merge
Member
|
@alinaliBQ can you rebase here? |
Address more feedback Avoid using "using" in Headers Add `server->Wait` call Co-Authored-By: justing-bq <[email protected]>
alinaliBQ
force-pushed
the
gh-46584-iterate-endpoint
branch
from
4da0d4a to
70ba716
Compare
Contributor
Author
|
@lidavidm Thanks and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GH-46584
What changes are included in this PR?
Iterate over endpoints to get data
Are these changes tested?
Tested in CI and locally on Windows MSVC. Test
flight_sql_stream_chunk_buffer_test.ccis addedAre there any user-facing changes?
N/A