GH-44810: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make() #48285

hiroyuki-sato · 2025-11-28T11:42:45Z

Rationale for this change

FileReader::Make previously returned Status and required callers to pass an out parameter.

What changes are included in this PR?

Introduce a Result<std::unique_ptr<FileReader>> returning API to allow clearer error propagation

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Status version FileReader::Make has been deprecated.

  static ::arrow::Status Make(::arrow::MemoryPool* pool,
                              std::unique_ptr<ParquetFileReader> reader,
                              const ArrowReaderProperties& properties,
                              std::unique_ptr<FileReader>* out);

  static ::arrow::Status Make(::arrow::MemoryPool* pool,
                              std::unique_ptr<ParquetFileReader> reader,
                              std::unique_ptr<FileReader>* out);

GitHub Issue: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make() #44810

github-actions · 2025-11-28T11:43:13Z

⚠️ GitHub issue #44810 has been automatically assigned in GitHub to PR creator.

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

cpp/src/parquet/arrow/reader.cc

cpp/src/parquet/arrow/reader.h

hiroyuki-sato

@kou CI passed Please take a look when you get a chacne.

cpp/src/parquet/arrow/reader_writer_benchmark.cc

…arrow::FileReader::Make()

Co-authored-by: Sutou Kouhei <[email protected]>

hiroyuki-sato · 2025-12-08T04:05:26Z

@kou Could you check this PR when you get a chance?

kou · 2025-12-08T08:45:53Z

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

  std::unique_ptr<FileReader> arrow_reader;
-  ASSERT_OK(FileReader::Make(default_memory_pool(), std::move(reader), &arrow_reader));
+  ASSERT_OK_AND_ASSIGN(arrow_reader,


Suggested change

std::unique_ptr<FileReader> arrow_reader;

ASSERT_OK(FileReader::Make(default_memory_pool(), std::move(reader), &arrow_reader));

ASSERT_OK_AND_ASSIGN(arrow_reader,

ASSERT_OK_AND_ASSIGN(auto arrow_reader,

kou · 2025-12-08T08:46:58Z

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

    std::unique_ptr<FileReader> reader;
-    ASSERT_OK_NO_THROW(
-        FileReader::Make(default_memory_pool(), std::move(file_reader), &reader));
+    ASSERT_OK_AND_ASSIGN(reader,
+                         FileReader::Make(default_memory_pool(), std::move(file_reader)));


Suggested change

std::unique_ptr<FileReader> reader;

ASSERT_OK_NO_THROW(

FileReader::Make(default_memory_pool(), std::move(file_reader), &reader));

ASSERT_OK_AND_ASSIGN(reader,

FileReader::Make(default_memory_pool(), std::move(file_reader)));

ASSERT_OK_AND_ASSIGN(auto reader,

FileReader::Make(default_memory_pool(), std::move(file_reader)));

kou · 2025-12-08T08:47:12Z

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

  std::unique_ptr<FileReader> arrow_reader;
-  ASSERT_OK_NO_THROW(
-      FileReader::Make(pool, ParquetFileReader::OpenFile(path, false), &arrow_reader));
+  ASSERT_OK_AND_ASSIGN(arrow_reader,


Suggested change

std::unique_ptr<FileReader> arrow_reader;

ASSERT_OK_NO_THROW(

FileReader::Make(pool, ParquetFileReader::OpenFile(path, false), &arrow_reader));

ASSERT_OK_AND_ASSIGN(arrow_reader,

ASSERT_OK_AND_ASSIGN(auto arrow_reader,

kou · 2025-12-08T08:47:37Z

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

    std::unique_ptr<FileReader> reader;
-    ASSERT_OK_NO_THROW(
-        FileReader::Make(pool, ParquetFileReader::OpenFile(path, false), &reader));
+    ASSERT_OK_AND_ASSIGN(
+        reader, FileReader::Make(pool, ParquetFileReader::OpenFile(path, false)));


Suggested change

std::unique_ptr<FileReader> reader;

ASSERT_OK_NO_THROW(

FileReader::Make(pool, ParquetFileReader::OpenFile(path, false), &reader));

ASSERT_OK_AND_ASSIGN(

reader, FileReader::Make(pool, ParquetFileReader::OpenFile(path, false)));

ASSERT_OK_AND_ASSIGN(

auto reader, FileReader::Make(pool, ParquetFileReader::OpenFile(path, false)));

kou · 2025-12-08T08:47:48Z

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

  std::unique_ptr<FileReader> file_reader;
-  ASSERT_OK(
-      FileReader::Make(::arrow::default_memory_pool(), std::move(reader), &file_reader));
+  ASSERT_OK_AND_ASSIGN(
+      file_reader, FileReader::Make(::arrow::default_memory_pool(), std::move(reader)));


Suggested change

std::unique_ptr<FileReader> file_reader;

ASSERT_OK(

FileReader::Make(::arrow::default_memory_pool(), std::move(reader), &file_reader));

ASSERT_OK_AND_ASSIGN(

file_reader, FileReader::Make(::arrow::default_memory_pool(), std::move(reader)));

ASSERT_OK_AND_ASSIGN(

auto file_reader, FileReader::Make(::arrow::default_memory_pool(), std::move(reader)));

kou · 2025-12-08T08:48:58Z

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

  std::unique_ptr<FileReader> parquet_reader;
-  ASSERT_OK(FileReader::Make(pool, ParquetFileReader::OpenFile(file, false), properties,
-                             &parquet_reader));
+  ASSERT_OK_AND_ASSIGN(
+      parquet_reader,


Suggested change

std::unique_ptr<FileReader> parquet_reader;

ASSERT_OK(FileReader::Make(pool, ParquetFileReader::OpenFile(file, false), properties,

&parquet_reader));

ASSERT_OK_AND_ASSIGN(

parquet_reader,

ASSERT_OK_AND_ASSIGN(

auto parquet_reader,

kou · 2025-12-08T08:49:08Z

cpp/src/parquet/arrow/arrow_reader_writer_test.cc

  std::unique_ptr<FileReader> arrow_reader;
-  ASSERT_OK(FileReader::Make(pool, std::move(reader), read_properties, &arrow_reader));
+  ASSERT_OK_AND_ASSIGN(arrow_reader,


Suggested change

std::unique_ptr<FileReader> arrow_reader;

ASSERT_OK(FileReader::Make(pool, std::move(reader), read_properties, &arrow_reader));

ASSERT_OK_AND_ASSIGN(arrow_reader,

ASSERT_OK_AND_ASSIGN(auto arrow_reader,

kou · 2025-12-08T08:51:48Z

cpp/src/parquet/arrow/reader_writer_benchmark.cc

+    auto arrow_reader_result =
+        FileReader::Make(::arrow::default_memory_pool(), std::move(reader));
+    EXIT_NOT_OK(arrow_reader_result.status());
+    std::shared_ptr<FileReader> arrow_reader = std::move(*arrow_reader_result);


Suggested change

std::shared_ptr<FileReader> arrow_reader = std::move(*arrow_reader_result);

auto arrow_reader = std::move(*arrow_reader_result);

kou · 2025-12-08T08:52:05Z

cpp/src/parquet/arrow/reader_writer_benchmark.cc

+    auto arrow_reader_result =
+        FileReader::Make(::arrow::default_memory_pool(), std::move(reader));
+    EXIT_NOT_OK(arrow_reader_result.status());
+    std::shared_ptr<FileReader> arrow_reader = std::move(*arrow_reader_result);


Suggested change

std::shared_ptr<FileReader> arrow_reader = std::move(*arrow_reader_result);

auto arrow_reader = std::move(*arrow_reader_result);

kou · 2025-12-08T08:53:02Z

cpp/src/parquet/arrow/reader_writer_benchmark.cc

+    auto arrow_reader_result =
+        FileReader::Make(::arrow::default_memory_pool(), std::move(reader));
+    EXIT_NOT_OK(arrow_reader_result.status());
+    std::shared_ptr<FileReader> arrow_reader = std::move(*arrow_reader_result);


Suggested change

std::shared_ptr<FileReader> arrow_reader = std::move(*arrow_reader_result);

auto arrow_reader = std::move(*arrow_reader_result);

hiroyuki-sato requested a review from wgtmac as a code owner November 28, 2025 11:42

github-actions bot added Component: Parquet Component: C++ awaiting review Awaiting review labels Nov 28, 2025

kou reviewed Nov 28, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes awaiting change review Awaiting change review labels Nov 28, 2025

hiroyuki-sato force-pushed the topic/parquet-result-reader branch from 86eba06 to 7ef530c Compare November 29, 2025 12:47

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 29, 2025

hiroyuki-sato commented Dec 1, 2025

View reviewed changes

cpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated Show resolved Hide resolved

kou reviewed Dec 1, 2025

View reviewed changes

cpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated Show resolved Hide resolved

cpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated Show resolved Hide resolved

cpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated Show resolved Hide resolved

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Dec 1, 2025

hiroyuki-sato commented Dec 2, 2025

View reviewed changes

cpp/src/parquet/arrow/reader_writer_benchmark.cc Outdated Show resolved Hide resolved

github-actions bot added awaiting changes Awaiting changes Component: Gandiva awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Dec 2, 2025

hiroyuki-sato and others added 3 commits December 8, 2025 09:44

apacheGH-44810: [C++][Parquet] Add arrow::Result version of parquet::…

78669ae

…arrow::FileReader::Make()

Update cpp/src/parquet/arrow/arrow_reader_writer_test.cc

25b243d

Co-authored-by: Sutou Kouhei <[email protected]>

Update cpp/src/parquet/arrow/arrow_reader_writer_test.cc

5253e5f

Co-authored-by: Sutou Kouhei <[email protected]>

hiroyuki-sato and others added 14 commits December 8, 2025 09:44

Update cpp/src/parquet/arrow/arrow_reader_writer_test.cc

8a1a250

Co-authored-by: Sutou Kouhei <[email protected]>

Update cpp/src/parquet/arrow/reader.cc

c667080

Co-authored-by: Sutou Kouhei <[email protected]>

Update cpp/src/parquet/arrow/reader.cc

e3ba67f

Co-authored-by: Sutou Kouhei <[email protected]>

Update cpp/src/parquet/arrow/reader.h

fcce0f9

Co-authored-by: Sutou Kouhei <[email protected]>

Status version FileReader::Make set to deprecated

f535aba

Replace to ASSERT_OK_AND_ASSIGN

2f77602

Added error checking in case an error occurs

5a759b1

Added error checking in case an error occurs

481687d

Add missing ()

0ba452e

Fix variable name

b73d808

Use Result version FileReader::Make

007c6f3

Replace Result verion FileReader::Make

517e4a5

Fix segfault

5c2990c

Fix lint

e3a041b

hiroyuki-sato force-pushed the topic/parquet-result-reader branch from c3bb1d2 to 39cc9ea Compare December 8, 2025 00:44

Replace Result verion FileReader::Make

45249dd

hiroyuki-sato force-pushed the topic/parquet-result-reader branch from 39cc9ea to 45249dd Compare December 8, 2025 00:50

github-actions bot removed the Component: Gandiva label Dec 8, 2025

kou reviewed Dec 8, 2025

View reviewed changes

hiroyuki-sato added 2 commits December 9, 2025 12:07

Use auto

b0b6205

Fix lint

a3d9777

	std::shared_ptr<FileReader> arrow_reader = std::move(*arrow_reader_result);
	auto arrow_reader = std::move(*arrow_reader_result);

GH-44810: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make() #48285

Are you sure you want to change the base?

GH-44810: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make() #48285

Conversation

hiroyuki-sato commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hiroyuki-sato left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hiroyuki-sato commented Dec 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hiroyuki-sato commented Nov 28, 2025 •

edited

Loading