GH-48314: [Python] Compat with pandas 3.0 changed default datetime unit #48319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
requested review from
AlenkaF,
raulcd and
rok
as code owners
|
|
github-actions
bot
added
Component: Python
awaiting committer review
Member
Author
|
@github-actions crossbow submit test-conda-python-3.13-pandas-nightly-numpy-nightly test-conda-python-3.13-pandas-upstream_devel-numpy-nightly |
pitrou
reviewed
Dec 3, 2025
| [(1, 'a', 2.0), (2, 'b', 3.0), (3, 'c', 4.0)], | ||
| columns=pd.date_range( | ||
| start='2017-01-01', periods=3, tz='America/New_York' | ||
| start='2017-01-01', periods=3, tz='America/New_York', unit='us' |
Member
There was a problem hiding this comment.
Do we want to parametrize this test on datetime unit or is it superfluous?
|
Revision: f0afc77 Submitted crossbow builds: ursacomputing/crossbow @ actions-bfea497ea7
|
Member
|
Unrelated, but do we want to remove compatibility with very old Pandas versions at some point? Pandas 1.3.4 was released in 2021 and only provides wheels for Python 3.10 and earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
pandas 3.0 changes the default datetime/timedelta resolution from nanoseconds to microseconds. We already had mostly accounted for that in previous PRs, but pandas made this change the last days in a few additional places (eg
pd.date_range), uncovering some more issuesWhat changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No