[CALCITE-6685] There is no support for checked arithmetic #4044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation adds support for checked arithmetic in Calcite.
This solves some bugs which are at least 12 years old in Calcite, such as FNL_25.
This implementation only handles pure arithmetic. Aggregates are not handled currently, but using the existing framework it should become very easy.
The core idea is as follows:
The handling of Decimals is a bit different: there is not checked arithmetic for decimals, but casts to decimals perform overflow checking. As such, casts to decimals may not be elided from the program even if they seem noops (the input type matches the output type).