Fix incorrect data file length for early open sstables #4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Branimir Lambov; reviewed by TBD for CASSANDRA-20592
smiklosovic
reviewed
Apr 24, 2025
| @VisibleForTesting | ||
| public int sizeOfFile(String filePath) | ||
| { | ||
| return (int) cache.asMap().keySet().stream().filter(x -> x.path.equals(filePath)).count(); |
There was a problem hiding this comment.
Depending on this being on a hot path or not we might contemplate about removing streams in favor of plain for loop.
https://lists.apache.org/thread/65glsjzkmpktzmns6j9wvr4nczvskx36
There was a problem hiding this comment.
It is only meant to be used in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSANDRA-20592
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format: