CASSANDRA-20581 Improved observability in AutoRepair to report both expected vs. actual repair bytes and expected vs. actual keyspaces #4126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,13 +86,22 @@ public abstract class AutoRepairState | |||
| @VisibleForTesting | |||
| protected int skippedTablesCount = 0; | |||
| @VisibleForTesting | |||
| protected long totalBytesToRepair = 0; | |||
There was a problem hiding this comment.
In future, we can extend by adding expected/actual partitions, token ranges, etc.
| List<PrioritizedRepairPlan> repairPlans = PrioritizedRepairPlan.build(keyspacesAndTablesToRepair, repairType, shuffleFunc); | ||
| List<PrioritizedRepairPlan> repairPlans = PrioritizedRepairPlan.build(keyspacesAndTablesToRepair, repairType, shuffleFunc, primaryRangeOnly); | ||
|
|
||
| int keyspaceRepairPlansSofar = 0; |
There was a problem hiding this comment.
It is cumbersome to identify if a keyspace has been completely repaired or not, due to our priority-based allotment. In most cases, when priority is not set, one keyspace=one keyspaceRepairPlans. I agree that it is hard for end users to differentiate between keyspace vs. keyspaceRepairPlans if priority is set, but in the beginning, we can target accuracy for use cases/operators that have no priority set
clohfink
reviewed
Apr 29, 2025
| @VisibleForTesting | ||
| protected int totalKeyspaceRepairPlansToRepair = 0; | ||
| @VisibleForTesting | ||
| protected int keyspacesRepairPlansAlreaydRepaired = 0; |
There was a problem hiding this comment.
sp: keyspacesRepairPlansAlreadyRepaired
clohfink
reviewed
Apr 29, 2025
| @@ -101,6 +112,19 @@ protected RepairCoordinator getRepairRunnable(String keyspace, RepairOption opti | |||
| options, keyspace); | |||
| } | |||
|
|
|||
| public void calcExpectedScheduleStats(List<PrioritizedRepairPlan> repairPlans) | |||
There was a problem hiding this comment.
nitpick: rename to something like calculateRepairPlanStatistics or updateScheduleStatistics to be more descriptive (feel free to ignore)
jaydeepkumar1984
force-pushed
the
trunk_cassandra_20581
branch
19 times, most recently
from
bffa9e2 to
fc6bd13
Compare
smiklosovic
changed the title
jaydeepkumar1984
force-pushed
the
trunk_cassandra_20581
branch
6 times, most recently
from
166174a to
71ea40d
Compare
jaydeepkumar1984
force-pushed
the
trunk_cassandra_20581
branch
8 times, most recently
from
2322b33 to
13b1667
Compare
jaydeepkumar1984
changed the title
jaydeepkumar1984
force-pushed
the
trunk_cassandra_20581
branch
7 times, most recently
from
13c09a3 to
18a1e0a
Compare
jaydeepkumar1984
commented
May 7, 2025
| @@ -1186,4 +1196,197 @@ public static Collection<Range<Token>> split(Range<Token> tokenRange, int number | |||
| } | |||
| return ranges; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Moved the following APIs from RepairTokenRangeSplitter.java to here
| * @param tableNames tables to repair for the given keyspace. | ||
| * @return Single repair plan. | ||
| */ | ||
| static List<PrioritizedRepairPlan> buildSingleKeyspacePlan(AutoRepairConfig.RepairType repairType, String keyspaceName, String ... tableNames) |
There was a problem hiding this comment.
Removed this API because it was only being used in testing. Created a similar API under unit/*
jaydeepkumar1984
force-pushed
the
trunk_cassandra_20581
branch
2 times, most recently
from
2f35462 to
390a08b
Compare
…al repair bytes and expected vs. actual keyspaces
jaydeepkumar1984
force-pushed
the
trunk_cassandra_20581
branch
from
390a08b to
dc743fd
Compare
jaydeepkumar1984
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a draft PR intended to gather early feedback. Test cases, code structure, and other refinements are not yet finalized.
Overall, we want to improve the AutoRepair scheduler's observability. The whole work will be divided into multiple PRs, with this PR adding the following two capabilities:
With this PR, we can visualize something like
The Cassandra Jira