CASSANDRA-20291 Filter unreachable private IPs from batch log writing #4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add filtering logic to remove reachable private IPs from list of nodes to be selected for batch log writes. Patch By Manish Khandelwal, Reviewed by TBD for CASSANDRA-20291
| @@ -45,7 +49,8 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
|
|
|||
| import com.carrotsearch.hppc.ObjectIntHashMap; | |||
| import com.carrotsearch.hppc.cursors.ObjectObjectCursor; | |||
There was a problem hiding this comment.
I think the imports should be moved back.
| @@ -269,7 +281,7 @@ public static ReplicaPlan.ForWrite forBatchlogWrite(boolean isAny) throws Unavai | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| public static Collection<InetAddressAndPort> filterBatchlogEndpoints(boolean preferLocalRack, String localRack, | |||
| public static Collection<InetAddressAndPort> filterBatchlogEndpoints(boolean preferLocalRack, String localRack, | |||
| continue; | ||
|
|
||
| // Check for intra dc connectivity on private network. Cache the result for 30 seconds. | ||
| // Valid for topology where two newtwork interfaces are used. |
| } | ||
|
|
||
|
|
| @@ -414,13 +446,86 @@ public static Collection<InetAddressAndPort> filterBatchlogEndpointsDynamic(bool | |||
| if (result.contains(endpoint)) | |||
| continue; | |||
|
|
|||
|
|
|||
| } | ||
| } | ||
| @VisibleForTesting | ||
| public static class CacheEntry |
| } | ||
|
|
||
| // Check reachability with cache | ||
| private static boolean isReachableWithCache(InetAddressAndPort address, int timeoutMs) { |
| return reachable; | ||
| } | ||
|
|
||
| private static boolean isReachableOnce(InetAddressAndPort address, int timeoutMs) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add filtering logic to remove reachable private IPs from list of nodes to be selected for batch log writes. Patch By Manish Khandelwal, Reviewed by TBD for CASSANDRA-20291
This patch handles batch log writing in case of loss of private IP connectivity with multi interface enabled ( public ip for multi data center). This logic is