Skip to content

Conversation

Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Oct 20, 2025

Description

This PR fixes the response object for traffic type, which is required for the go-SDK (in turn needed for terraform issue)

This fixes #11860

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (f63118c) to head (7d666c1).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11875   +/-   ##
=========================================
  Coverage     17.55%   17.56%           
- Complexity    15529    15533    +4     
=========================================
  Files          5909     5909           
  Lines        529012   529012           
  Branches      64604    64604           
=========================================
+ Hits          92892    92914   +22     
+ Misses       425671   425651   -20     
+ Partials      10449    10447    -2     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@poddm
Copy link

poddm commented Oct 21, 2025

Is it possible to include all the fields used during creation in the list response? This would make Terraform state management more complete.

See. #7837

These fields are not returned from the List API

  • traffictype (fixed here)
  • hypervnetworklabel
  • kvmnetworklabel
  • ovm3networklabel
  • isolationmethod
  • vlan
  • vmwarenetworklabel
  • xennetworklabel

@Pearl1594
Copy link
Contributor Author

Is it possible to include all the fields used during creation in the list response? This would make Terraform state management more complete.

See. #7837

These fields are not returned from the List API

* traffictype (fixed here)

* hypervnetworklabel

* kvmnetworklabel

* ovm3networklabel

* isolationmethod

* vlan

* vmwarenetworklabel

* xennetworklabel

this seems to be addressed with: #8151 @poddm

@weizhouapache
Copy link
Member

@blueorangutan package

@weizhouapache weizhouapache added this to the 4.22.1 milestone Oct 21, 2025
@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15516

@weizhouapache
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14709)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 65900 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11875-t14709-kvm-ol8.zip
Smoke tests completed. 147 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestAccounts>:setup Error 0.00 test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup Error 0.00 test_accounts.py
test_DeleteDomain Error 16.73 test_accounts.py
test_forceDeleteDomain Failure 17.36 test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup Error 17.93 test_accounts.py
ContextSuite context=TestTemplateHierarchy>:setup Error 21.04 test_accounts.py
ContextSuite context=TestISO>:setup Error 1553.26 test_iso.py

Copy link

@pavanaravapalli pavanaravapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM.

@Pearl1594
Copy link
Contributor Author

Is it possible to include all the fields used during creation in the list response? This would make Terraform state management more complete.

See. #7837

These fields are not returned from the List API

* traffictype (fixed here)

* hypervnetworklabel

* kvmnetworklabel

* ovm3networklabel

* isolationmethod

* vlan

* vmwarenetworklabel

* xennetworklabel

@poddm there's a PR already raised to address these missing parameters in the response : #8151. Now that I see it, this change is also present on that PR. If there's no activity there, I'll port the changes on to this new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants