-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Traffic type response object #11875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11875 +/- ##
=========================================
Coverage 17.55% 17.56%
- Complexity 15529 15533 +4
=========================================
Files 5909 5909
Lines 529012 529012
Branches 64604 64604
=========================================
+ Hits 92892 92914 +22
+ Misses 425671 425651 -20
+ Partials 10449 10447 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is it possible to include all the fields used during creation in the list response? This would make Terraform state management more complete. See. #7837 These fields are not returned from the List API
|
|
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15516 |
@blueorangutan test |
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-14709)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM.
@poddm there's a PR already raised to address these missing parameters in the response : #8151. Now that I see it, this change is also present on that PR. If there's no activity there, I'll port the changes on to this new PR. |
Description
This PR fixes the response object for traffic type, which is required for the go-SDK (in turn needed for terraform issue)
This fixes #11860
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?