fix: Add preference for WKWebView crash recovery behaviour#1582
Merged
Conversation
This adds a `CrashRecoveryBehavior` preference with options `"refresh"` (default - try to refresh the WebView URL) and `"reload"` (load the starting page again in the WebView). This doesn't solve the root issue where sometimes refreshing the WebView still results in a blank screen, but gives people the option to force a full reload (which seems to be what people are using as a workaround for the blank screen bug). Closes apacheGH-1232. Closes apacheGH-1235. Closes apacheGH-1355. Closes apacheGH-1393. Closes apacheGH-1533. Closes apacheGH-1552.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1582 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 17 17
Lines 4911 4911
=======================================
Hits 3867 3867
Misses 1044 1044 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erisu
approved these changes
Nov 8, 2025
Member
There was a problem hiding this comment.
LGTM
Built a Cordova test app and tested the following cases:
- No settings: After crashing the WebContent, the app's WebView reloaded and the previously set hash value remained in the
href. CrashRecoveryBehaviorset torefresh: After crashing the WebContent, the app's WebView reloaded and the previously set hash value remained in thehref.CrashRecoveryBehaviorset toreload: After crashing the WebContent, the app's WebView reloaded and thehrefresets to the original starting URL.
erisu
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Provide a preference to control whether the WKWebView will refresh or reload completely after a crash.
Closes GH-1232.
Closes GH-1235.
Closes GH-1355.
Closes GH-1393.
Closes GH-1533.
Closes GH-1552.
Description
This adds a
CrashRecoveryBehaviorpreference with options"refresh"(default - try to refresh the WKWebView URL) and"reload"(load the starting page again in the WKWebView).This doesn't solve the root issue where sometimes refreshing the WKWebView after a crash results in a blank screen, but gives people the option to force a full reload (which seems to be what people are using as a workaround for the blank screen bug).
Testing
Added API tests to confirm the intended behaviour.
Checklist