fix: Add preference for WKWebView crash recovery behaviour #1582
+231
−116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Provide a preference to control whether the WKWebView will refresh or reload completely after a crash.
Closes GH-1232.
Closes GH-1235.
Closes GH-1355.
Closes GH-1393.
Closes GH-1533.
Closes GH-1552.
Description
This adds a
CrashRecoveryBehaviorpreference with options"refresh"(default - try to refresh the WKWebView URL) and"reload"(load the starting page again in the WKWebView).This doesn't solve the root issue where sometimes refreshing the WKWebView after a crash results in a blank screen, but gives people the option to force a full reload (which seems to be what people are using as a workaround for the blank screen bug).
Testing
Added API tests to confirm the intended behaviour.
Checklist