Skip to content

Conversation

@erisu
Copy link
Member

@erisu erisu commented Nov 8, 2025

This PR is currently set as draft while waiting for [email protected] release.

Motivation and Context

Drop ios-sim and use simctl directly.

Closes #567

Description

Removed usage of ios-sim. Fetching of iOS simulators and running on simulator logic to call simctl directly.

Testing

  • npm t
  • built Cordova sample app.
  • Ran cordova run ios --list
  • Ran cordova run ios

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 8.0.0 milestone Nov 8, 2025
@erisu erisu requested a review from dpogue November 8, 2025 03:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 36.75418% with 265 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.45%. Comparing base (6b39d0e) to head (84668f9).

Files with missing lines Patch % Lines
lib/simctlHelper.js 34.13% 191 Missing ⚠️
lib/run.js 37.31% 42 Missing ⚠️
lib/listEmulatorImages.js 46.66% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
- Coverage   78.74%   75.45%   -3.29%     
==========================================
  Files          17       18       +1     
  Lines        4911     5255     +344     
==========================================
+ Hits         3867     3965      +98     
- Misses       1044     1290     +246     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu force-pushed the feat/use-simctl-directly branch from 4b63095 to 84668f9 Compare November 8, 2025 03:24
@dpogue dpogue linked an issue Nov 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

advisory: don't upgrade to ios-sim 9.x

2 participants