Skip to content

Fix replication job rewinds #6040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickva merged 1 commit into from
Jun 16, 2026
+20 −1
Merged

Fix replication job rewinds #6040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/couch_replicator/src/couch_replicator_filters.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ parse(Options) ->
{undefined, _, undefined} ->
{ok, {docids, DocIds}};
{undefined, undefined, _} ->
{ok, {mango, ejsort(mango_selector:normalize(Selector))}};
% We need paths to hashed with <<"a.b">> form not the new
% normalized [<<"a">>, <<"b">>] form
Normalized = mango_util:join_keys(mango_selector:normalize(Selector)),
{ok, {mango, ejsort(Normalized)}};
_ ->
Err = "`selector`, `filter` and `doc_ids` are mutually exclusive",
{error, list_to_binary(Err)}
Expand Down Expand Up @@ -217,4 +220,20 @@ ejsort_compound_values_test() ->
{[{<<"x">>, Ej1s}, {<<"y">>, [Ej1s, Ej1s]}, {<<"z">>, Ej1s}]}
).

% Regression tests for replication checkpoint stability. The hashed mango
% selector must use field paths with dots: <<"a.b">> or we get rewinds!
mango_selector_single_field_path_test() ->
Sel = {[{<<"name">>, <<"x">>}]},
?assertEqual(
{ok, {mango, {[{<<"name">>, {[{<<"$eq">>, <<"x">>}]}}]}}},
parse([{selector, Sel}])
).

mango_selector_nested_field_path_test() ->
Sel = {[{<<"a">>, {[{<<"b">>, 1}]}}]},
?assertEqual(
{ok, {mango, {[{<<"a.b">>, {[{<<"$eq">>, 1}]}}]}}},
parse([{selector, Sel}])
).

-endif.