Reduce equal method candidates log from WARNING to FINE#2954
Open
Reduce equal method candidates log from WARNING to FINE#2954
Conversation
The "Both X and Y are equal candidates" message fires during normal CORS preflight handling where wildcard media types are used, producing noisy logs. Downgrade to FINE since the behavior is deterministic and users can enable debug logging to investigate ambiguous routing. Closes #862 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Drop misleading "unpredictable results" phrasing (the sort is stable) and use a lambda supplier to avoid string concatenation overhead when FINE logging is disabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ffang
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WARNINGtoFINE(debug) level inOperationResourceInfoComparatorBaseCrossOriginResourceSharingFilter.findPreflightMethod()usesMediaType.WILDCARD, causing all methods on the same path to match equallySupersedes #862 with a simpler fix — rather than changing the CORS filter to pass real media types, we simply reduce the noise level of a message that fires in expected scenarios.
Test plan
🤖 Generated with Claude Code