fix: handle None task slot in update_task_info after executor lost #1523
Open
milenkovicm wants to merge 1 commit intoapache:mainfrom
Open
fix: handle None task slot in update_task_info after executor lost #1523milenkovicm wants to merge 1 commit intoapache:mainfrom
milenkovicm wants to merge 1 commit intoapache:mainfrom
Conversation
…pache#23) When an executor heartbeat times out, reset_tasks() sets task_infos[partition_id] to None. If the executor later reconnects and sends a late status update, update_task_info() would panic on .unwrap() of the None value. Now gracefully returns false (update rejected) with a warning log when the task slot is None, preventing the scheduler from crashing. Fixes spiceai/spiceai#9636
Contributor
Author
|
@phillipleblanc i've back-ported this to ballista, I hope its ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When an executor heartbeat times out, reset_tasks() sets task_infos[partition_id] to None. If the executor later reconnects and sends a late status update, update_task_info() would panic on .unwrap() of the None value.
Now gracefully returns false (update rejected) with a warning log when the task slot is None, preventing the scheduler from crashing.
What changes are included in this PR?
this is back-port of spiceai/spiceai#9636
Are there any user-facing changes?