feat: enable decimal to decimal cast of different precision and scale #1086
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
reviewed
Nov 15, 2024
| @@ -895,6 +895,18 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { | |||
| } | |||
| } | |||
|
|
|||
| test("cast between decimals with different precision and scale") { | |||
There was a problem hiding this comment.
It's great to see that some basic tests now pass. I assume there must have been improvements in DataFusion since we started this project.
I'd like to see the tests cover more scenarios, such as:
- Casting from smaller scale to larger scale e.g. (10, 1) to (10, 4)
- Tests for edge cases such as negative scale and zero scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #375
Rationale for this change
What changes are included in this PR?
How are these changes tested?