Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Restore one test in CometExecSuite by adding COMET_SHUFFLE_MODE config #1087

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 14, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Just found this test doesn't actually test what it did. We need to add specified COMET_SHUFFLE_MODE config to restore it.

What changes are included in this PR?

How are these changes tested?

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit 7cec285 into apache:main Nov 15, 2024
75 checks passed
@viirya viirya deleted the fix_test branch November 15, 2024 00:48
@viirya
Copy link
Member Author

viirya commented Nov 15, 2024

Thanks @huaxingao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants