Add SBT support for project #1383
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Which issue does this PR close? ## Rationale for this change Current Comet unified memory pool is a greedy pool. One thread (consumer) can take a large amount of memory that causes OOM for other threads, especially for aggregation. ## What changes are included in this PR? Added a fair version of unified memory pool similar to DataFusion `FairSpilPool` that caps the memory usage at `pool_size/num` The fair unified memory pool is the default for off-heap mode with this PR ## How are these changes tested? Exisiting tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1344
Rationale for this change
Should optimize incremental compilation and allow for much faster development and tests cycles.
Modernizes the work environment.
What changes are included in this PR?
Simply added a build.sbt file, plugins.sbt file. and updated some docs.
How are these changes tested?
Simply by running "sbt assembly", or with added profiles "sbt assembly -Dspark3.4 -Dscala2.12 -DLinux-amd64", or whichever ones you use.